pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
2+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
@ 2026-01-19 09:17 "vlsi (@vlsi)" <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: vlsi (@vlsi) @ 2026-01-19 09:17 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
@ 2026-01-19 14:21 "mjschwaiger (@mjschwaiger)" <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: mjschwaiger (@mjschwaiger) @ 2026-01-19 14:21 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java)

Wouldn't it be more efficient to test the main/default case of AutoSave.NEVER first, thereby avoiding these string comparisons inside `isSpecialQuery` most of the time?
```
if (getAutoSave() == AutoSave.NEVER) {
    return false;
}
if (isSpecialQuery(query)) {
    return false;
}
```

^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2026-01-19 14:21 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-19 09:17 [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs "vlsi (@vlsi)" <[email protected]>
2026-01-19 14:21 Re: [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs "mjschwaiger (@mjschwaiger)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox