Re: Proposal: recent access based routing for primary-replica setups

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Nadav Shatz <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Subject: Re: Proposal: recent access based routing for primary-replica setups
Date: Sun, 21 Dec 2025 13:06:10 +0200
Message-ID: <CACeKOO2urqxJAvKS_BrBTLnEjo75ZFBYN2+++e55GgjzzC_B5w@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CACeKOO3kSTnAsjQMmuYFAFDG513W4KeAX=vZ7NVaFafMy9KFXQ@mail.gmail.com>
	<[email protected]>
	<CACeKOO17CEiuBoV-V-ZzLPPW4yEMt6+m3y+9Ys6Ky_=fEAJZLg@mail.gmail.com>
	<[email protected]>

--00000000000005ddad0646744dfd
Content-Type: multipart/alternative; boundary="00000000000005ddac0646744dfb"

--00000000000005ddac0646744dfb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I think everything is passing now. new version attached.

On Mon, Nov 24, 2025 at 9:41=E2=80=AFAM Tatsuo Ishii <[email protected]>=
 wrote:

> Thank you for updating the patch! This time the patch applies without
> any issue and compiles fine. Unfortunately regression test failed.
>
> testing 041.external_replication_delay...failed.
>
> From the regression log, it seems Test7 failed.
>
> -------------------------------------------------------------------------=
-----
> =3D=3D=3D Test7: Command timeout handling =3D=3D=3D
> waiting for server to start....411181 2025-11-24 16:31:05.244 JST LOG:
> redirecting log output to logging collector process
> 411181 2025-11-24 16:31:05.244 JST HINT:  Future log output will appear i=
n
> directory "log".
>  done
> server started
> waiting for server to start....411196 2025-11-24 16:31:05.352 JST LOG:
> redirecting log output to logging collector process
> 411196 2025-11-24 16:31:05.352 JST HINT:  Future log output will appear i=
n
> directory "log".
>  done
> server started
> waiting for server to start....411213 2025-11-24 16:31:05.461 JST LOG:
> redirecting log output to logging collector process
> 411213 2025-11-24 16:31:05.461 JST HINT:  Future log output will appear i=
n
> directory "log".
>  done
> server started
> Waiting for command timeout...
> fail: command timeout not detected
>
> -------------------------------------------------------------------------=
-----
>
> Attached is the pgpool.log. If you need more info, please let me know.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
>
> > Hi Tatsuo,
> >
> > Sorry again, this was due to the separation of 2 patches and i only sen=
t
> > the one.
> >
> > I've merged it into 1 commit and 1 patch and rebased over master to avo=
id
> > these issues moving forward.
> >
> > PFA latest version
> >
> > On Thu, Nov 20, 2025 at 1:09=E2=80=AFAM Tatsuo Ishii <ishii@postgresql.=
org>
> wrote:
> >
> >> Hi Nadav,
> >>
> >> Thank you for new patch.
> >> Unfortunately the patch did not apply to current master.
> >>
> >> $ git apply
> >> ~/0001-Fix-multiple-issues-in-external-replication-delay-fe.patch
> >> error: patch failed: src/streaming_replication/pool_worker_child.c:694
> >> error: src/streaming_replication/pool_worker_child.c: patch does not
> apply
> >>
> >> Maybe the patch is on top of your previous patch?
> >>
> >> Also I suggest to use "-v" option of "git format-patch" to add the
> >> patch version number so that we can easily know which patch is the
> >> latest.
> >>
> >> Best regards,
> >> --
> >> Tatsuo Ishii
> >> SRA OSS K.K.
> >> English: http://www.sraoss.co.jp/index_en/
> >> Japanese:http://www.sraoss.co.jp
> >>
> >> > Hi Tatsuo,
> >> >
> >> > Please see attached an updated version.
> >> >
> >> > thank you
> >> >
> >> > On Fri, Nov 7, 2025 at 2:07=E2=80=AFAM Tatsuo Ishii <ishii@postgresq=
l.org>
> >> wrote:
> >> >
> >> >> > Sorry for that - thanks for the patch.
> >> >> >
> >> >> > Please find attached a new version
> >> >>
> >> >> Thanks for the new version. Unfortunately this time regression test
> >> >> fails at:
> >> >>
> >> >> > Waiting for command timeout...
> >> >> > fail: command timeout not detected
> >> >>
> >> >> Attached is the pgpool.log.
> >> >>
> >> >> Best regards,
> >> >> --
> >> >> Tatsuo Ishii
> >> >> SRA OSS K.K.
> >> >> English: http://www.sraoss.co.jp/index_en/
> >> >> Japanese:http://www.sraoss.co.jp
> >> >>
> >> >> > On Mon, Nov 3, 2025 at 9:05=E2=80=AFAM Tatsuo Ishii <ishii@postgr=
esql.org>
> >> >> wrote:
> >> >> >
> >> >> >> > thanks and sorry for the issues, please find attached updated
> >> version.
> >> >> >>
> >> >> >> No problem.
> >> >> >>
> >> >> >> This time the patch applies fine, no compiler warnings.  However=
,
> >> >> >> regression test did not passed here (on Ubuntu 24 LTS if this
> >> >> >> matters).  So I looked into
> >> >> >> src/test/regression/tests/041.external_replication_delay/test.sh=
 a
> >> >> >> little bit and apply attached patch (test.sh.patch). It moved
> forward
> >> >> >> partially but failed at:
> >> >> >>
> >> >> >> fail: command execution failure not detected
> >> >> >>
> >> >> >> Please find attached
> >> >> >>
> >> >>
> >>
> src/test/regression/tests/041.external_replication_delay/testdir/pgpool.l=
og
> >> >> >> and src/test/regression/log/041.external_replication_delay.
> >> >> >>
> >> >> >> Best regards,
> >> >> >> --
> >> >> >> Tatsuo Ishii
> >> >> >> SRA OSS K.K.
> >> >> >> English: http://www.sraoss.co.jp/index_en/
> >> >> >> Japanese:http://www.sraoss.co.jp
> >> >> >>
> >> >> >
> >> >> >
> >> >> > --
> >> >> > Nadav Shatz
> >> >> > Tailor Brands | CTO
> >> >>
> >> >
> >> >
> >> > --
> >> > Nadav Shatz
> >> > Tailor Brands | CTO
> >>
> >
> >
> > --
> > Nadav Shatz
> > Tailor Brands | CTO
>


--=20
Nadav Shatz
Tailor Brands | CTO

--00000000000005ddac0646744dfb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I think everything=C2=A0is passing now. new version attach=
ed.</div><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"l=
tr" class=3D"gmail_attr">On Mon, Nov 24, 2025 at 9:41=E2=80=AFAM Tatsuo Ish=
ii &lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thank yo=
u for updating the patch! This time the patch applies without<br>
any issue and compiles fine. Unfortunately regression test failed.<br>
<br>
testing 041.external_replication_delay...failed.<br>
<br>

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Proposal: recent access based routing for primary-replica setups
  In-Reply-To: <CACeKOO2urqxJAvKS_BrBTLnEjo75ZFBYN2+++e55GgjzzC_B5w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox