From: Simon Riggs <simon@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: George Wilk <gwilk@ellacoya.com>
Cc: pgsql-admin@postgresql.org
Subject: Re: missing history file
Date: Mon, 02 Jul 2007 10:35:56 +0100
Message-ID: <1183368957.3589.160.camel@silverbirch.site> (raw)
In-Reply-To: <12838.1183128750@sss.pgh.pa.us>
References: <008401c7ba44$5efa4170$0d7ba8c0@ellacoya.com>
<1183124513.3589.104.camel@silverbirch.site>
<12838.1183128750@sss.pgh.pa.us>
On Fri, 2007-06-29 at 10:52 -0400, Tom Lane wrote:
> "Simon Riggs" <simon@2ndquadrant.com> writes:
> > Just ignore 00000001. Recovery will work fine even if absent. Don't
> > ignore all history files though, just that one. Hmmm, come to think of
> > it, why is it requesting it at all? We should just skip that request.
>
> No, because then people would misdesign their recovery scripts to not
> be able to deal with not finding a history file. As things are, they
> will certainly be exposed to that case in any testing they do. If we
> optimize this call away, then they won't see the case until they're in
> very deep doo-doo.
Main reason for suggesting this is that there is already code to
optimize the call away in one place, but not in another, which seems
strange either way.
--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: simon@2ndquadrant.com, tgl@sss.pgh.pa.us, gwilk@ellacoya.com
Subject: Re: missing history file
In-Reply-To: <1183368957.3589.160.camel@silverbirch.site>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox