pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Mark Kirkwood <markir@coretech.co.nz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PITR COPY Failure (was Point in Time Recovery)
Date: Tue, 20 Jul 2004 10:00:35 -0400
Message-ID: <13342.1090332035@sss.pgh.pa.us> (raw)
In-Reply-To: <1090329086.28049.2708.camel@stromboli>
References: <200407141555.i6EFtnk22984@mail.osdl.org>
	<1089833620.17493.4624.camel@stromboli>
	<40F5E14A.4090003@coretech.co.nz>
	<1089875702.17493.5539.camel@stromboli>
	<40F652C6.4070007@coretech.co.nz>
	<1089935215.17493.6906.camel@stromboli>
	<40FA0F93.8010607@coretech.co.nz>
	<40FC6BF2.5050701@coretech.co.nz>
	<3607.1090296869@sss.pgh.pa.us>
	<1090324635.28049.2554.camel@stromboli>
	<7787.1090327914@sss.pgh.pa.us>
	<1090329086.28049.2708.camel@stromboli>

Simon Riggs <simon@2ndquadrant.com> writes:
> On Tue, 2004-07-20 at 13:51, Tom Lane wrote:
>> Ugh.  I'm beginning to think we ought to revert the patch that added the
>> don't-split-across-files logic to XLogInsert; that seems to have broken
>> more assumptions than I realized.

> The problem was that a zero length XLOG_WASTED_SPACE record just fell
> out of ReadRecord when it shouldn't have. By giving it a helping hand it
> makes it through with pointers correctly set, and everything else was
> already thought of in the earlier patch, so xlog_redo etc happens.

Yeah, but the WASTED_SPACE/FILE_HEADER stuff is already pretty ugly, and
adding two more warts to the code to support it is sticking in my craw.
I'm thinking it would be cleaner to treat the extra labeling information
as an extension of the WAL page header.

			regards, tom lane



view thread (19+ messages)  latest in thread

Message-ID: <13342.1090332035@sss.pgh.pa.us>
Permalink:  ../13342.1090332035@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13342.1090332035@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, markir@coretech.co.nz, pgsql-hackers@postgresql.org
  Subject: Re: PITR COPY Failure (was Point in Time Recovery)
  In-Reply-To: <13342.1090332035@sss.pgh.pa.us>
  References: <200407141555.i6EFtnk22984@mail.osdl.org> <1089833620.17493.4624.camel@stromboli> <40F5E14A.4090003@coretech.co.nz> <1089875702.17493.5539.camel@stromboli> <40F652C6.4070007@coretech.co.nz> <1089935215.17493.6906.camel@stromboli> <40FA0F93.8010607@coretech.co.nz> <40FC6BF2.5050701@coretech.co.nz> <3607.1090296869@sss.pgh.pa.us> <1090324635.28049.2554.camel@stromboli> <7787.1090327914@sss.pgh.pa.us> <1090329086.28049.2708.camel@stromboli> <13342.1090332035@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox