From: Stephen Frost <sfrost@snowman.net>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Evan Rempel <erempel@uvic.ca>
Cc: pgsql-admin@postgresql.org, Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [ADMIN] 9.5 new setting "cluster name" and logging
Date: Mon, 8 Feb 2016 15:42:06 -0500
Message-ID: <20160208204206.GV3331@tamriel.snowman.net> (raw)
In-Reply-To: <CAEepm=3vqzfOuPa=L-qQWuHE5FJWJoWQc3N6aGS_-70Bz1oo8Q@mail.gmail.com>
References: <1377186808.57546.YahooMailNeo@web193505.mail.sg3.yahoo.com>
<A737B7A37273E048B164557ADEF4A58B17C08086@ntex2010a.host.magwien.gv.at>
<1377494614.9111.YahooMailNeo@web193506.mail.sg3.yahoo.com>
<A737B7A37273E048B164557ADEF4A58B17C0876C@ntex2010a.host.magwien.gv.at>
<56AC5601.5040208@uvic.ca>
<20160208142429.5by57csmc75gorg7@alap3.anarazel.de>
<56B8C2B9.8020009@joeconway.com>
<CAEepm=3vqzfOuPa=L-qQWuHE5FJWJoWQc3N6aGS_-70Bz1oo8Q@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Thomas,
* Thomas Munro (thomas.munro@enterprisedb.com) wrote:
> On Tue, Feb 9, 2016 at 5:30 AM, Joe Conway <mail@joeconway.com> wrote:
> > On 02/08/2016 06:24 AM, Andres Freund wrote:
> >> On 2016-01-29 22:19:45 -0800, Evan Rempel wrote:
> >>> Now that there is a setting to give a cluster a "name", it would be nice to
> >>> have an escape sequence in the log_line_prefix setting that could reference
> >>> the cluster_name.
> >>
> >> I've argued[1][2] for this when cluster_name was introduced, but back
> >> then I seemed to have been the only one arguing for it. Josh later
> >> jumped that train.
> >>
> >> Given that we now had a number of people wishing for this, can we maybe
> >> reconsider?
> >
> > Seems like a reasonable idea to me. But if we add a log_line_prefix
> > setting, shouldn't we also add it to csvlog output too?
>
> Here's a tiny patch adding support for %C to log_line_prefix (this was
> part of the cluster_name patch that didn't go it).
>
> Given that csvlog's output format is hardcoded in write_csvlog, how is
> it supposed to evolve without upsetting consumers of this data?
> Wouldn't we first need to add a GUC that lets you control the columns
> it outputs?
Not sure if you really want to go there, but I do agree with you and
there's a thread from a few years back about something similar:
http://www.postgresql.org/message-id/flat/20110112142345.GA4933@tamriel.snowman.net
Included in that thread is a patch, which likely requires some dusting
off, to add exactly that ability.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: sfrost@snowman.net, thomas.munro@enterprisedb.com, mail@joeconway.com, andres@anarazel.de, erempel@uvic.ca, pgsql-hackers@postgresql.org
Subject: Re: [ADMIN] 9.5 new setting "cluster name" and logging
In-Reply-To: <20160208204206.GV3331@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox