From: Nathan Bossart <nathandbossart@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Don Seiler <don@seiler.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Estimating HugePages Requirements?
Date: Mon, 28 Mar 2022 10:35:03 -0700
Message-ID: <20220328173503.GA137769@nathanxps13> (raw)
In-Reply-To: <20220324203108.GB1855897@nathanxps13>
References: <YTmMLtoLEAjMuRSm@paquier.xyz>
<6AE0285D-0917-4C05-B6AA-4AEDD2FCBA52@amazon.com>
<CABUevEweO_ZxTQox=QoO8e3rZQm9qFVU+zdoQvazTH9F7HpdEQ@mail.gmail.com>
<20220314173417.GA1020555@nathanxps13>
<Yi/82cqnpKkZsOjI@paquier.xyz>
<CABUevExgoKMNveD5SvFWOYA4MQvPkDmGxY7DkVRASJED4gBYog@mail.gmail.com>
<20220315224439.GA1133771@nathanxps13>
<Yjq9bJe28newGZaK@paquier.xyz>
<CABUevEyExSDrtZ4wU19iX4yvgExR1EpjFKB4ExFQDgTAvAHFyg@mail.gmail.com>
<20220324203108.GB1855897@nathanxps13>
On Thu, Mar 24, 2022 at 01:31:08PM -0700, Nathan Bossart wrote:
> A couple of other options to consider:
>
> 1) Always set log_min_messages to WARNING/ERROR/FATAL for 'postgres -C'.
> We might need some special logic for handling the case where the user is
> inspecting the log_min_messages parameter. With this approach, you'd
> probably never get extra output unless something was wrong (e.g., database
> already running when inspecting a runtime-computed GUC). Also, this would
> silence any extra output that you might see today with non-runtime-computed
> GUCs.
>
> 2) Add some way to skip just the shutdown message (e.g., a variable set
> when output_config_variable is true). With this approach, you wouldn't get
> extra output by default, but you still might if log_min_messages is set to
> something like DEBUG3. This wouldn't impact any extra output that you see
> today with non-runtime-computed GUCs.
I've attached a first attempt at option 1.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.comAttachments:
v3-0001-Silence-extra-logging-with-postgres-C.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: nathandbossart@gmail.com, magnus@hagander.net, michael@paquier.xyz, bossartn@amazon.com, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, andres@anarazel.de, mark.dilger@enterprisedb.com, don@seiler.us, pgsql-hackers@postgresql.org
Subject: Re: Estimating HugePages Requirements?
In-Reply-To: <20220328173503.GA137769@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox