public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Bossart, Nathan <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: Don Seiler <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Estimating HugePages Requirements?
Date: Tue, 10 May 2022 09:12:49 -0700
Message-ID: <20220510161249.GA3715618@nathanxps13> (raw)
In-Reply-To: <[email protected]>
References: <20220315224439.GA1133771@nathanxps13>
<[email protected]>
<CABUevEyExSDrtZ4wU19iX4yvgExR1EpjFKB4ExFQDgTAvAHFyg@mail.gmail.com>
<[email protected]>
<CABUevEwPPxR-SD55UWDLZuLa2UVGY+OQpVPPvO82X10MU_hLcA@mail.gmail.com>
<[email protected]>
<CABUevEyD_aLM=oXi1jj8hRN=7aJq--jN4FP+ehY8Vu60+QH61A@mail.gmail.com>
<YmdMDiCCyVJLlB/[email protected]>
<20220506171318.GA3448558@nathanxps13>
<[email protected]>
On Mon, May 09, 2022 at 03:53:24PM +0900, Michael Paquier wrote:
> I have looked at the patch posted at [1], and I don't quite understand
> why you need the extra dance with log_min_messages. Why don't you
> just set the GUC at the end of the code path in PostmasterMain() where
> we print non-runtime-computed parameters?
The log_min_messages dance avoids extra output when inspecting
non-runtime-computed GUCs, like this:
~/pgdata$ postgres -D . -C log_min_messages -c log_min_messages=debug5
debug5
2022-05-10 09:06:04.728 PDT [3715607] DEBUG: shmem_exit(0): 0 before_shmem_exit callbacks to make
2022-05-10 09:06:04.728 PDT [3715607] DEBUG: shmem_exit(0): 0 on_shmem_exit callbacks to make
2022-05-10 09:06:04.728 PDT [3715607] DEBUG: proc_exit(0): 0 callbacks to make
2022-05-10 09:06:04.728 PDT [3715607] DEBUG: exit(0)
AFAICT you need to set log_min_messages to at least DEBUG3 to see extra
output for the non-runtime-computed GUCs, so it might not be worth the
added complexity.
> I am not really worrying
> about users deciding to set log_min_messages to PANIC in
> postgresql.conf when it comes to postgres -C, TBH, as they'd miss the
> FATAL messages if the command is attempted on a server already
> starting.
I don't have a strong opinion on this one.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (108+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Estimating HugePages Requirements?
In-Reply-To: <20220510161249.GA3715618@nathanxps13>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox