From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Wells Oliver <wells.oliver@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-admin <pgsql-admin@postgresql.org>
Subject: Re: Odd pg dump error: cache lookup failure
Date: Mon, 26 Oct 2020 13:52:58 -0400
Message-ID: <737423.1603734778@sss.pgh.pa.us> (raw)
In-Reply-To: <20201023185144.GA16041@alvherre.pgsql>
References: <20201023185144.GA16041@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> [ v3 patches ]
This looks committable to me, with one trivial nit:
in LockViewRecurse_walker, it'd be better to not do get_rel_name()
(or even fetch rte->relid, really) until we've verified the rtekind.
As-is, it's wasting cycles and presuming more than it ought to
about the error behavior of get_rel_name(). That's a pre-existing
problem not the fault of this patch, but we might as well fix it
while we're here.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, wells.oliver@gmail.com, sfrost@snowman.net
Subject: Re: Odd pg dump error: cache lookup failure
In-Reply-To: <737423.1603734778@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox