From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: dx k9 <bitsandbytes88@hotmail.com>
Cc: pgsql-admin@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: reindexdb hangs
Date: Thu, 30 Aug 2007 14:54:21 -0400
Message-ID: <7460.1188500061@sss.pgh.pa.us> (raw)
In-Reply-To: <20070830164151.GS5872@alvh.no-ip.org>
References: <BAY116-F2261C1BEF758D30196729DD1420@phx.gbl>
<22018.1178144703@sss.pgh.pa.us>
<20070825222150.GU31461@alvh.no-ip.org>
<4909.1188082313@sss.pgh.pa.us>
<20070829222341.GX7911@alvh.no-ip.org>
<12577.1188428726@sss.pgh.pa.us>
<20070830164151.GS5872@alvh.no-ip.org>
Alvaro Herrera <alvherre@commandprompt.com> writes:
> I'm not sure I follow. Are you suggesting adding a new function,
> similar to pg_class_ownercheck, which additionally checks for temp-ness?
No, I was just suggesting adding the check for temp-ness in cluster()
and cluster_rel() where we do pg_class_ownercheck. We already have the
rel open there and so it's cheap to do the temp-ness check.
I guess it's a question of which path you are more concerned about
making cheap, of course. Your proposal was to filter before putting the
rel into the list at all, which certainly saves cycles when we reject a
remote temp table; but it adds cycles for all other tables. I argue
that the remote-temp-table case is uncommon (else we'd have had many
more trouble reports) and therefore optimizing it at the cost of the
normal case isn't a win.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@commandprompt.com, bitsandbytes88@hotmail.com, pgsql-hackers@postgresql.org
Subject: Re: reindexdb hangs
In-Reply-To: <7460.1188500061@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox