pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-admin@postgresql.org
Subject: Re: PITR Error Message assistance
Date: Wed, 30 Jun 2004 10:58:44 -0400
Message-ID: <8886.1088607524@sss.pgh.pa.us> (raw)
In-Reply-To: <200406300849.18058.peter_e@gmx.net>
References: <auto-000005536314@davinci.ethosmedia.com>
	<200406291036.48477.josh@agliodbs.com>
	<1088541547.3266.7534.camel@stromboli>
	<200406300849.18058.peter_e@gmx.net>

Peter Eisentraut <peter_e@gmx.net> writes:
> Simon Riggs wrote:
>> + elog(WARNING, "could not set notify for archiver to read log file
>> %u, segment %u",

> Reason? (disk full, network down, leap year?)

> I think elog() calls don't get translated.  You should always use 
> ereport.  Tom would know more about the distinction.

elog is deprecated except for debugging or "can't-happen" messages.
Anything user-facing ought to be reported with ereport.  In this case
elog might be okay --- it's not clear to me from this snippet whether
the condition is one a user would be likely to see.

There's plenty of detail about all this in chapter 45 of the docs:
http://www.postgresql.org/docs/7.4/static/source.html
and I think most of Peter's comments trace directly to items in the
message style guide there.

			regards, tom lane



view thread (5+ messages)  latest in thread

Message-ID: <8886.1088607524@sss.pgh.pa.us>
Permalink:  ../8886.1088607524@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8886.1088607524@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter_e@gmx.net, simon@2ndquadrant.com
  Subject: Re: PITR Error Message assistance
  In-Reply-To: <8886.1088607524@sss.pgh.pa.us>
  References: <auto-000005536314@davinci.ethosmedia.com> <200406291036.48477.josh@agliodbs.com> <1088541547.3266.7534.camel@stromboli> <200406300849.18058.peter_e@gmx.net> <8886.1088607524@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox