From: John Scalia <jayknowsunix@gmail.com>
To: Michael Banck <michael.banck@credativ.de>
Cc: David Morton <david.morton@eroad.com>
Cc: pgsql-admin@lists.postgresql.org <pgsql-admin@lists.postgresql.org>
Subject: Re: Upgrading 9.6.9 to 10.4
Date: Wed, 11 Jul 2018 12:54:26 -0400
Message-ID: <E8CB52F6-7A4E-4871-9668-80A9C0867D14@gmail.com> (raw)
In-Reply-To: <20180711163633.GL23217@nighthawk.caipicrew.dd-dns.de>
References: <8D4726EE-74E8-494B-9ED1-817EF2BB5E4B@gmail.com>
<55998B04-BB01-45F9-B478-BCE1DA4E8E6E@eroad.com>
<67BBE981-45B6-4CC8-BA3C-DF9210D46D8F@gmail.com>
<20180711163633.GL23217@nighthawk.caipicrew.dd-dns.de>
Tried several branches including the one you specified. None of them mentioned the newly revised PostgreSQL functions that were causing the compilation to break. I did manage to alter the code so it will now build with either 9.6 or the 10.4 instance. Was just sharing my experience as it was certainly broken prior.
Sent from my iPhone
> On Jul 11, 2018, at 12:36 PM, Michael Banck <michael.banck@credativ.de> wrote:
>
> Hi John,
>
>> On Wed, Jun 27, 2018 at 03:53:20PM -0400, John Scalia wrote:
>> Ok, I figured out why the Makefile is broken for pglogical for
>> PostgreSQL V.10. The pg_config utility returned 10.4 for the line
>> setting Makefile parameter PGVER. Adding a simple “| cut -c1-2 to that
>> line allows the Makefile to run for 9.6 and 10.4, probably other
>> versions as well.
>
> (10.4 isn't a major version, it's the fourth minor/patch release of the
> v10 major version).
>
> If you don't have the `| cut -c 1-2' in your Makefile then you're
> probably looking at the wrong branch, the pglogical master branch on
> github is stale, you need (for reasons that escape me) the REL2_x_STABLE
> branch. Or probably the 2.2.0 release tarball would work just as fine.
>
>> There are compile problems, however, in several source files. I don’t
>> have the code in front of me, but one doing heap work calls
>> replorigin_drop with a single argument, but that changed in V10 to
>> need 2 args. Fairly easy to fix that one.
>>
>> Another source calls ExecARUpdateTriggers, and its friends Insert and
>> Delete, those signatures have changed as well, and I haven’t yet
>> figured out how to alter pglogical for compiling these.
>
> I assume those failues are addressed in the above branch/release as
> well, but I have not verified that.
>
>
> Cheers
>
> Michael
>
> --
> Michael Banck
> Projektleiter / Senior Berater
> Tel.: +49 2166 9901-171
> Fax: +49 2166 9901-100
> Email: michael.banck@credativ.de
>
> credativ GmbH, HRB Mönchengladbach 12080
> USt-ID-Nummer: DE204566209
> Trompeterallee 108, 41189 Mönchengladbach
> Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
>
> Unser Umgang mit personenbezogenen Daten unterliegt
> folgenden Bestimmungen: https://www.credativ.de/datenschutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: jayknowsunix@gmail.com, michael.banck@credativ.de, david.morton@eroad.com, pgsql-admin@lists.postgresql.org
Subject: Re: Upgrading 9.6.9 to 10.4
In-Reply-To: <E8CB52F6-7A4E-4871-9668-80A9C0867D14@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox