pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: robionekenobi@bluewin.ch
To: 'Juan José Santamaría Flecha' <juanjo.santamaria@gmail.com>
To: 'PostgreSQL mailing lists' <pgsql-bugs@lists.postgresql.org>
Subject: RE: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
Date: Sun, 17 Jan 2021 09:31:16 +0100
Message-ID: <000001d6ecab$1f6c43c0$5e44cb40$@bluewin.ch> (raw)
In-Reply-To: <CAC+AXB1hEoM+=c6OnNfeDNZzvKtQBuo4qo7W9AkUBNVYEjAqYg@mail.gmail.com>
References: <16825-c4f104bcebc67034@postgresql.org>
	<CAC+AXB1hEoM+=c6OnNfeDNZzvKtQBuo4qo7W9AkUBNVYEjAqYg@mail.gmail.com>

Hi,

 

Yes, I see

 

Don’t know why when I’m doing the cl /? In the Visual Studio path of the x64 Native Command Prompt, the response contains all the help (including the /flavor: ….)

 

Once I change to the postgresql\src\tools\msvc for to build, the ‘cl /?’ Only gives back 2 lines and say invalid option.

 

But I also remarked that if you pass ‘cl -?’, it works correctly in both case. Do you think it is possible to change the ‘cl /?’ by ‘cl -?’ ?

 

Thanks for your help

 

Regards

Robert

 

 

From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> 
Sent: Saturday, January 16, 2021 10:16 PM
To: robionekenobi@bluewin.ch; PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment

 

 

 

On Fri, Jan 15, 2021 at 9:21 AM PG Bug reporting form < <mailto:noreply@postgresql.org> noreply@postgresql.org> wrote:


in src\tools\msvc\Solution.pm the following test is not sufficient
                $self->{platform} =
                  ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : 'Win32';
because the cl /? returns:
                Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29336 for x64
                Copyright (C) Microsoft Corporation.  All rights reserved.

 

I see no bug here, that expression is looking for the line: "/favor:<blend|AMD64|INTEL64|ATOM> select processor to optimize for, one of:", which is one of the first printed options.

To make sure this is working in your environment, you should see "Detected hardware platform: x64" when building.

 

Regards,

 

Juan José Santamaría Flecha

 

 

 

view thread (11+ messages)  latest in thread

Message-ID: <000001d6ecab$1f6c43c0$5e44cb40$@bluewin.ch>
Permalink:  ../000001d6ecab$1f6c43c0$5e44cb40$@bluewin.ch/
Also on:    postgresql.org/message-id/000001d6ecab$1f6c43c0$5e44cb40$@bluewin.ch

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: robionekenobi@bluewin.ch, juanjo.santamaria@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: RE: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
  In-Reply-To: <000001d6ecab$1f6c43c0$5e44cb40$@bluewin.ch>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox