pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Regina Obe <lr@pcorp.us>
To: 'Tom Lane' <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: RE: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
Date: Thu, 11 Mar 2021 11:45:47 -0500
Message-ID: <000201d71695$fdd14ed0$f973ec70$@pcorp.us> (raw)
In-Reply-To: <2294904.1615480631@sss.pgh.pa.us>
References: <16920-2332590daf58407c@postgresql.org>
	<2291040.1615474929@sss.pgh.pa.us>
	<000501d71691$c616a200$5243e600$@pcorp.us>
	<2294904.1615480631@sss.pgh.pa.us>

> Our usual recommendation is to include postgres.h before all else; is
there a
> really good reason to be pulling in libxml headers before that?
> 
> Having seen this, I now guess that your issue is happening because one of
> those headers has already included <sys/stat.h> before win32_port.h tries
to
> do so.  That makes our attempt to relabel the system's "struct stat" as
"struct
> microsoft_native_stat" not work.
> In general, the portability hacks that postgres.h does for some platforms
> aren't reliable if any system headers have already been pulled in.
> 
> 			regards, tom lane

I don't think there is a reason to include libxml first.  Thanks for the
help.  I'll revise those to see if it fixes the issue without messing with
the Postgres include files.

Thanks,
Regina






view thread (33+ messages)  latest in thread

Message-ID: <000201d71695$fdd14ed0$f973ec70$@pcorp.us>
Permalink:  ../000201d71695$fdd14ed0$f973ec70$@pcorp.us/
Also on:    postgresql.org/message-id/000201d71695$fdd14ed0$f973ec70$@pcorp.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: lr@pcorp.us, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
  Subject: RE: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head
  In-Reply-To: <000201d71695$fdd14ed0$f973ec70$@pcorp.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox