pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedMissing whitespace in pg_restore manpage
4+ messages / 2 participants
[nested] [flat]
* Missing whitespace in pg_restore manpage
@ 2025-04-14 09:55 Lele Gaifax <lele@metapensiero.it>
0 siblings, 1 reply; 4+ messages in thread
From: Lele Gaifax @ 2025-04-14 09:55 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org
Hi all,
the manpage for "pg_restore" tool, in its "--filter" option description,
is missing a whitespace after the reference to "--exclude-schema"
option:
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 0ba68ad5305..b6de497aee1 100644
--- a/doc/src/sgml/ref/pg_restore.sgml
+++ b/doc/src/sgml/ref/pg_restore.sgml
@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
All the best,
bye, lele.
--
nickname: Lele Gaifax | Some people, when confronted with a problem, think "I
real: Emanuele Gaifas | know, I'll use threads." Nothwey htwo pavroble ems.
lele@metapensiero.it | -- Steven D'Aprano, paraphrasing Jamie Zawinski
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Missing whitespace in pg_restore manpage
@ 2025-04-15 05:47 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: Lele Gaifax <lele@metapensiero.it>
0 siblings, 1 reply; 4+ messages in thread
From: Fujii Masao @ 2025-04-15 05:47 UTC (permalink / raw)
To: Lele Gaifax <lele@metapensiero.it>; pgsql-bugs@lists.postgresql.org
On 2025/04/14 18:55, Lele Gaifax wrote:
> Hi all,
>
> the manpage for "pg_restore" tool, in its "--filter" option description,
> is missing a whitespace after the reference to "--exclude-schema"
> option:
>
> diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
> index 0ba68ad5305..b6de497aee1 100644
> --- a/doc/src/sgml/ref/pg_restore.sgml
> +++ b/doc/src/sgml/ref/pg_restore.sgml
> @@ -231,7 +231,7 @@ PostgreSQL documentation
> or included from restore. The patterns are interpreted according to the
> same rules as
> <option>-n</option>/<option>--schema</option> for including objects in schemas,
> - <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
> + <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
> <option>-P</option>/<option>--function</option> for restoring named functions,
> <option>-I</option>/<option>--index</option> for restoring named indexes,
> <option>-t</option>/<option>--table</option> for restoring named tables
Thanks for the report! I think you're right, and I've created a patch
based on your suggestion.
Since this typo was introduced in v17, the patch should be back-patched
to that branch as well.
By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email.
Could you let me know which name you'd prefer to use as the author in
the commit message? For now, I've used "Lele Gaifax" in the attached patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From d9e944a3457bc04763a9c0b3d3e0cfa3ee3d634d Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Tue, 15 Apr 2025 14:39:03 +0900
Subject: [PATCH v1] doc: Fix missing whitespace in pg_restore documentation.
Previously, a space was missing between "<option>--exclude-schema</option>"
and "for" in the pg_restore documentation. This commit fixes the typo by
adding the missing whitespace.
Back-patch to v17 where the typo was added.
Author: Lele Gaifax <lele@metapensiero.it>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/87lds3ysm0.fsf@metapensiero.it
Backpatch-through: 17
---
doc/src/sgml/ref/pg_restore.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 0ba68ad5305..b6de497aee1 100644
--- a/doc/src/sgml/ref/pg_restore.sgml
+++ b/doc/src/sgml/ref/pg_restore.sgml
@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
--
2.49.0
Attachments:
v1-0001-doc-Fix-missing-whitespace-in-pg_restore-document.patch (text/plain, 1.6K) download
From d9e944a3457bc04763a9c0b3d3e0cfa3ee3d634d Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Tue, 15 Apr 2025 14:39:03 +0900
Subject: [PATCH v1] doc: Fix missing whitespace in pg_restore documentation.
Previously, a space was missing between "<option>--exclude-schema</option>"
and "for" in the pg_restore documentation. This commit fixes the typo by
adding the missing whitespace.
Back-patch to v17 where the typo was added.
Author: Lele Gaifax <lele@metapensiero.it>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/87lds3ysm0.fsf@metapensiero.it
Backpatch-through: 17
---
doc/src/sgml/ref/pg_restore.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
index 0ba68ad5305..b6de497aee1 100644
--- a/doc/src/sgml/ref/pg_restore.sgml
+++ b/doc/src/sgml/ref/pg_restore.sgml
@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
--
2.49.0
* Re: Missing whitespace in pg_restore manpage
@ 2025-04-15 05:56 Lele Gaifax <lele@metapensiero.it>
parent: Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: Lele Gaifax @ 2025-04-15 05:56 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; pgsql-bugs@lists.postgresql.org
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email.
> Could you let me know which name you'd prefer to use as the author in
> the commit message? For now, I've used "Lele Gaifax" in the attached patch.
I confirm the choice, thank you!
bye, lele.
--
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it | -- Fortunato Depero, 1929.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Missing whitespace in pg_restore manpage
@ 2025-04-15 14:19 Fujii Masao <masao.fujii@oss.nttdata.com>
parent: Lele Gaifax <lele@metapensiero.it>
0 siblings, 0 replies; 4+ messages in thread
From: Fujii Masao @ 2025-04-15 14:19 UTC (permalink / raw)
To: Lele Gaifax <lele@metapensiero.it>; pgsql-bugs@lists.postgresql.org
On 2025/04/15 14:56, Lele Gaifax wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>
>> By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email.
>> Could you let me know which name you'd prefer to use as the author in
>> the commit message? For now, I've used "Lele Gaifax" in the attached patch.
>
> I confirm the choice, thank you!
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-04-15 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-14 09:55 Missing whitespace in pg_restore manpage Lele Gaifax <lele@metapensiero.it>
2025-04-15 05:47 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2025-04-15 05:56 ` Lele Gaifax <lele@metapensiero.it>
2025-04-15 14:19 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox