From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Lele Gaifax <lele@metapensiero.it>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: Missing whitespace in pg_restore manpage
Date: Tue, 15 Apr 2025 14:47:19 +0900
Message-ID: <508337df-2ea5-469a-b4be-920d0378dcdb@oss.nttdata.com> (raw)
In-Reply-To: <87lds3ysm0.fsf@metapensiero.it>
References: <87lds3ysm0.fsf@metapensiero.it>
On 2025/04/14 18:55, Lele Gaifax wrote:
> Hi all,
>
> the manpage for "pg_restore" tool, in its "--filter" option description,
> is missing a whitespace after the reference to "--exclude-schema"
> option:
>
> diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml
> index 0ba68ad5305..b6de497aee1 100644
> --- a/doc/src/sgml/ref/pg_restore.sgml
> +++ b/doc/src/sgml/ref/pg_restore.sgml
> @@ -231,7 +231,7 @@ PostgreSQL documentation
> or included from restore. The patterns are interpreted according to the
> same rules as
> <option>-n</option>/<option>--schema</option> for including objects in schemas,
> - <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,
> + <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
> <option>-P</option>/<option>--function</option> for restoring named functions,
> <option>-I</option>/<option>--index</option> for restoring named indexes,
> <option>-t</option>/<option>--table</option> for restoring named tables
Thanks for the report! I think you're right, and I've created a patch
based on your suggestion.
Since this typo was introduced in v17, the patch should be back-patched
to that branch as well.
By the way, I noticed both "Lele Gaifax" and "Emanuele Gaifas" in your email.
Could you let me know which name you'd prefer to use as the author in
the commit message? For now, I've used "Lele Gaifax" in the attached patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From d9e944a3457bc04763a9c0b3d3e0cfa3ee3d634d Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Tue, 15 Apr 2025 14:39:03 +0900
Subject: [PATCH v1] doc: Fix missing whitespace in pg_restore documentation.
Previously, a space was missing between "<option>--exclude-schema</option>"
and "for" in the pg_restore documentation. This commit fixes the typo by
adding the missing whitespace.
Back-patch to v17 where the typo was added.
Author: Lele Gaifax <lele@metapensiero.it>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/87lds3ysm0.fsf@metapensiero.it
Backpatch-through: 17
---
doc/src/sgml/ref/pg_restore.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgmlindex 0ba68ad5305..b6de497aee1 100644--- a/doc/src/sgml/ref/pg_restore.sgml+++ b/doc/src/sgml/ref/pg_restore.sgml@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
--
2.49.0
Attachments:v1-0001-doc-Fix-missing-whitespace-in-pg_restore-document.patch (text/plain, 1.6K) download
From d9e944a3457bc04763a9c0b3d3e0cfa3ee3d634d Mon Sep 17 00:00:00 2001
From: Fujii Masao <fujii@postgresql.org>
Date: Tue, 15 Apr 2025 14:39:03 +0900
Subject: [PATCH v1] doc: Fix missing whitespace in pg_restore documentation.
Previously, a space was missing between "<option>--exclude-schema</option>"
and "for" in the pg_restore documentation. This commit fixes the typo by
adding the missing whitespace.
Back-patch to v17 where the typo was added.
Author: Lele Gaifax <lele@metapensiero.it>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/87lds3ysm0.fsf@metapensiero.it
Backpatch-through: 17
---
doc/src/sgml/ref/pg_restore.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgmlindex 0ba68ad5305..b6de497aee1 100644--- a/doc/src/sgml/ref/pg_restore.sgml+++ b/doc/src/sgml/ref/pg_restore.sgml@@ -231,7 +231,7 @@ PostgreSQL documentation
or included from restore. The patterns are interpreted according to the
same rules as
<option>-n</option>/<option>--schema</option> for including objects in schemas,
- <option>-N</option>/<option>--exclude-schema</option>for excluding objects in schemas,+ <option>-N</option>/<option>--exclude-schema</option> for excluding objects in schemas,
<option>-P</option>/<option>--function</option> for restoring named functions,
<option>-I</option>/<option>--index</option> for restoring named indexes,
<option>-t</option>/<option>--table</option> for restoring named tables
--
2.49.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, lele@metapensiero.it, pgsql-bugs@lists.postgresql.org
Subject: Re: Missing whitespace in pg_restore manpage
In-Reply-To: <508337df-2ea5-469a-b4be-920d0378dcdb@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox