From: Peter Eisentraut <peter@eisentraut.org>
To: muralikrishna.bandaru@enterprisedb.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib
Date: Tue, 18 Jun 2024 08:25:24 +0200
Message-ID: <080afa1e-476b-44f2-b052-4d669c23d290@eisentraut.org> (raw)
In-Reply-To: <18513-cf23db54997c9021@postgresql.org>
References: <18513-cf23db54997c9021@postgresql.org>
On 17.06.24 07:44, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18513
> Logged by: Muralikrishna Bandaru
> Email address: muralikrishna.bandaru@enterprisedb.com
> PostgreSQL version: 17beta1
> Operating system: Windows
> Description:
>
> PG17 build on windows is generating postgres.exe.lib. But all the previous
> versions generating postgres.lib file. Due to this renaming the extensions
> fail to link with this library by default as they expect postgres.lib. For
> example here is the link for system_stats project file
> https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101
>
> This seems like a bug, Can some one please confirm?
The attached patch might fix it. At least I appear to get the right
output file name. I don't have the ability to check whether it does the
right thing on Cygwin.
Attachments:0001-meson-Fix-import-library-name-in-Windows.patch (text/plain, 1.7K) download
From 3e6ef5bb0de6aa290fbf52296e5ba544c713fc67 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Tue, 18 Jun 2024 08:22:11 +0200
Subject: [PATCH] meson: Fix import library name in Windows
This changes the import library name from 'postgres.exe.lib' to
'postgres.lib', which is what it was with the old MSVC build system.
XXX check cygwin
Bug: #18513
Reported-by: Muralikrishna Bandaru <muralikrishna.bandaru@enterprisedb.com>
---
meson.build | 6 +++---
src/backend/meson.build | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/meson.build b/meson.buildindex 2767abd19e2..02929bb845f 100644--- a/meson.build+++ b/meson.build@@ -201,7 +201,7 @@ if host_system == 'cygwin'
cppflags += '-D_GNU_SOURCE'
dlsuffix = '.dll'
mod_link_args_fmt = ['@0@']
- mod_link_with_name = 'lib@0@.exe.a'+ mod_link_with_name = 'lib@0@.a'
mod_link_with_dir = 'libdir'
elif host_system == 'darwin'
@@ -273,10 +273,10 @@ elif host_system == 'windows'
export_file_suffix = 'def'
if cc.get_id() == 'msvc'
export_fmt = '/DEF:@0@'
- mod_link_with_name = '@0@.exe.lib'+ mod_link_with_name = '@0@.lib'
else
export_fmt = '@0@'
- mod_link_with_name = 'lib@0@.exe.a'+ mod_link_with_name = 'lib@0@.a'
endif
mod_link_args_fmt = ['@0@']
mod_link_with_dir = 'libdir'
diff --git a/src/backend/meson.build b/src/backend/meson.buildindex 436c04af080..78c57268142 100644--- a/src/backend/meson.build+++ b/src/backend/meson.build@@ -133,7 +133,7 @@ postgres = executable('postgres',
link_with: backend_link_with,
link_depends: backend_link_depends,
export_dynamic: true,
- implib: true,+ implib: 'postgres',
dependencies: backend_build_deps,
kwargs: default_bin_args,
)
--
2.45.2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter@eisentraut.org, muralikrishna.bandaru@enterprisedb.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib
In-Reply-To: <080afa1e-476b-44f2-b052-4d669c23d290@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox