From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Greg Hennessy <greg.hennessy@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Devrim Gündüz <devrim@gunduz.org>
Subject: Re: missing requirement on ccache in postgresql16-devel
Date: Wed, 25 Oct 2023 13:21:44 -0400
Message-ID: <1000999.1698254504@sss.pgh.pa.us> (raw)
In-Reply-To: <ZTlGvDyjfjPbnolk@momjian.us>
References: <CA+mZaON9nDxWrg=ABBczU3DuYwQ3Q02atsY+Xhb0ogAgHzmYVg@mail.gmail.com>
<ZTlGvDyjfjPbnolk@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> On Wed, Oct 25, 2023 at 11:25:15AM -0400, Greg Hennessy wrote:
>> The file /usr/pgsql-16/lib/pgxs/src/Makefile.global has a reference
>> to ccache but the rpm doesn't list this as a dependency. I would like
>> to submit that it is a bug that it does not.
> Uh, ccache is an _optional_ way to speed up compilation. It is not a
> requirement/dependency.
Yeah, but if the Makefile says "CC = ccache gcc" then anybody
trying to build under PGXS will fail if they don't have ccache
installed. So I think Greg has a point.
On typical Red Hat setups, it's not necessary to mention ccache
explicitly to use it; instead that's managed via PATH. For
example, I have
$ which gcc
/usr/lib64/ccache/gcc
$ ls -l /usr/lib64/ccache/gcc
lrwxrwxrwx. 1 root root 16 May 21 09:35 /usr/lib64/ccache/gcc -> ../../bin/ccache
so it Just Works. I'd suggest arranging the rpm builds to be
done similarly, and then you get ccache usage in the rpm build,
while the distributed Makefile will just say "CC = gcc" so
it will work for users whether they use ccache or not.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, greg.hennessy@gmail.com, devrim@gunduz.org
Subject: Re: missing requirement on ccache in postgresql16-devel
In-Reply-To: <1000999.1698254504@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox