From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: usamoi@outlook.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18637: CREATE INDEX won't look up operator classes in search_path if PARTITION BY is specified
Date: Sat, 05 Oct 2024 14:48:05 -0400
Message-ID: <1055980.1728154085@sss.pgh.pa.us> (raw)
In-Reply-To: <20241004023337.36.nmisch@google.com>
References: <18637-f51e314546e3ba2a@postgresql.org>
<CAApHDvrmBSTA8-Sv=HEQvrPO8QDPLB7y0d0gJweBQe2c8PMGYw@mail.gmail.com>
<231375.1727925543@sss.pgh.pa.us>
<364851.1727974294@sss.pgh.pa.us>
<427540.1727979435@sss.pgh.pa.us>
<20241004023337.36.nmisch@google.com>
Noah Misch <noah@leadboat.com> writes:
> On Thu, Oct 03, 2024 at 02:17:15PM -0400, Tom Lane wrote:
>> This could stand an additional regression test case perhaps,
>> but the core tests don't have a suitable opclass at hand.
>> Maybe we could test it in some contrib module, but that
>> seems a shade hacky.
> For contrib/citext/sql/create_index_acl.sql, I settled on testing in contrib.
> I valued the test fidelity of a real opclass more than I disliked the use of
> contrib. The distinction between the various parts of check-world is blurry
> to non-hackers, so I expect it won't bother them.
Agreed. Pushed it with a test added to contrib/seg, just to be
different.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, dgrowleyml@gmail.com, usamoi@outlook.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18637: CREATE INDEX won't look up operator classes in search_path if PARTITION BY is specified
In-Reply-To: <1055980.1728154085@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox