pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: khuddleston@pivotal.io, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14706: Dependencies not recorded properly for base types
Date: Thu, 15 Jun 2017 12:31:40 -0400
Message-ID: <11135.1497544300@sss.pgh.pa.us> (raw)
In-Reply-To: <91122adb-3afc-a727-c4c9-478175729f56@iki.fi>
References: <20170614232259.1424.82774@wrigleys.postgresql.org>
	<22824.1497487336@sss.pgh.pa.us>
	<CAB7nPqTyfyxiG2if30eMPRTx9=dTtBPKrLh2g6tNpa1B4=9LPA@mail.gmail.com>
	<1724.1497502434@sss.pgh.pa.us>
	<CAB7nPqRTpRtypR7gfqYLnmqytC1Xi_=sqnET=YWhSZENrNUz8g@mail.gmail.com>
	<CAB7nPqRUgybqbq-rBcpV_0Pp=YEhAfzxVOc0DoMKp56et4RpNw@mail.gmail.com>
	<91122adb-3afc-a727-c4c9-478175729f56@iki.fi>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Hmm. Strictly speaking there's no need to update the dependency when 
> changing opaque into cstring. Because cstring is a pinned type, 
> recordDependency will do nothing for it.

> But in any case, I think it'd be better and simpler to fix the 
> dependency in SetFunctionArgType() and SetFunctionReturnType() functions 
> themselves. They're the ones that change the type, they ought to be 
> responsible for fixing the dependency too. See attached.

Yeah, Heikki's version looks good to me.

Heikki, are you going to commit/backpatch this, or do you want me to?

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (15+ messages)  latest in thread

Message-ID: <11135.1497544300@sss.pgh.pa.us>
Permalink:  ../11135.1497544300@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11135.1497544300@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, hlinnaka@iki.fi, michael.paquier@gmail.com
  Subject: Re: BUG #14706: Dependencies not recorded properly for base types
  In-Reply-To: <11135.1497544300@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox