pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: khuddleston@pivotal.io, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14706: Dependencies not recorded properly for base types
Date: Fri, 16 Jun 2017 11:49:48 +0300
Message-ID: <15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi> (raw)
In-Reply-To: <CAB7nPqTuRMiJBQC65hg4MZVZeUPo1S9qPQ3sVYLw3+bbpEKQ_Q@mail.gmail.com>
References: <20170614232259.1424.82774@wrigleys.postgresql.org>
	<22824.1497487336@sss.pgh.pa.us>
	<CAB7nPqTyfyxiG2if30eMPRTx9=dTtBPKrLh2g6tNpa1B4=9LPA@mail.gmail.com>
	<1724.1497502434@sss.pgh.pa.us>
	<CAB7nPqRTpRtypR7gfqYLnmqytC1Xi_=sqnET=YWhSZENrNUz8g@mail.gmail.com>
	<CAB7nPqRUgybqbq-rBcpV_0Pp=YEhAfzxVOc0DoMKp56et4RpNw@mail.gmail.com>
	<91122adb-3afc-a727-c4c9-478175729f56@iki.fi>
	<11135.1497544300@sss.pgh.pa.us>
	<1c07c9a6-b56f-fe67-63a5-6913e78df1f6@iki.fi>
	<CAB7nPqTuRMiJBQC65hg4MZVZeUPo1S9qPQ3sVYLw3+bbpEKQ_Q@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

On 06/16/2017 04:54 AM, Michael Paquier wrote:
> On Fri, Jun 16, 2017 at 1:38 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> On 06/15/2017 07:31 PM, Tom Lane wrote:
>>>
>>> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>>>>
>>>> Hmm. Strictly speaking there's no need to update the dependency when
>>>> changing opaque into cstring. Because cstring is a pinned type,
>>>> recordDependency will do nothing for it.
>>>
>>>> But in any case, I think it'd be better and simpler to fix the
>>>> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
>>>> themselves. They're the ones that change the type, they ought to be
>>>> responsible for fixing the dependency too. See attached.
>>>
>>> Yeah, Heikki's version looks good to me.
>>>
>>> Heikki, are you going to commit/backpatch this, or do you want me to?
>>
>> I can do it, thanks.
>
> Fine for me. My first quick guess was better than what I coded at the
> end, the idea being to wait after TypeCreate() to get the ObjectAdress
> of the new type.

Ok, committed and backported, thanks!

- Heikki



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (15+ messages)

Message-ID: <15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi>
Permalink:  ../15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi/
Also on:    postgresql.org/message-id/15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: hlinnaka@iki.fi, michael.paquier@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: BUG #14706: Dependencies not recorded properly for base types
  In-Reply-To: <15dde5d7-46db-ff9b-64e1-e240535e9534@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox