pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vinod Sridharan <vsridh90@gmail.com>
Cc: niek.brasa@hitachienergy.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18831: Particular queries using gin-indexes are not interruptible, resulting is resource usage concerns.
Date: Sat, 12 Apr 2025 01:33:07 -0400
Message-ID: <1126691.1744435987@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFMdLD4Ks5b=CbBh1PjFSytm0zdNv9-ddyeE+opusAKCVph7=g@mail.gmail.com>
References: <18831-e845ac44ebc5dd36@postgresql.org>
	<474911.1741207802@sss.pgh.pa.us>
	<CAFMdLD7XzsXfi1+DpTqTgrD8XU0i2C99KuF=5VHLWjx4C1pkcg@mail.gmail.com>
	<1026035.1744415680@sss.pgh.pa.us>
	<CAFMdLD4SC1=NDOHL-LOAonb6aycv2D1MGbwdiT3M9=A7SfiXow@mail.gmail.com>
	<1098251.1744426831@sss.pgh.pa.us>
	<CAFMdLD4Ks5b=CbBh1PjFSytm0zdNv9-ddyeE+opusAKCVph7=g@mail.gmail.com>

Vinod Sridharan <vsridh90@gmail.com> writes:
> Since this is also called in the regular consistent function, this
> would be adding work in the regular consistent path - where the caller
> happens to reset the array for every invocation currently.

Ah, so you're just worried about the extra work in that path?
But MAX_MAYBE_ENTRIES is only 4, so I can't believe it'd amount
to much.

I am wondering about a test case.  I'm not thrilled about building
a specialized opclass just to test this.  contrib/hstore and
contrib/intarray already have opclasses with no triconsistent
function, so they should (and do) exercise shimTriConsistentFn
already.  But their tests failed to expose this bug.  I spent
a bit of time trying to add an example that would show the bug
in one or the other of those, and failed so far.  Any ideas?

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <1126691.1744435987@sss.pgh.pa.us>
Permalink:  ../1126691.1744435987@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1126691.1744435987@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, vsridh90@gmail.com, niek.brasa@hitachienergy.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18831: Particular queries using gin-indexes are not interruptible, resulting is resource usage concerns.
  In-Reply-To: <1126691.1744435987@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox