pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: stalkerg@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16791: Compile error with new ICU 68.2 for 10.15
Date: Fri, 25 Dec 2020 11:35:56 -0500
Message-ID: <1159815.1608914156@sss.pgh.pa.us> (raw)
In-Reply-To: <16791-f0b801625fc78400@postgresql.org>
References: <16791-f0b801625fc78400@postgresql.org>

PG Bug reporting form <noreply@postgresql.org> writes:
> Log:
> ```
> pg_collation.c:47:1: error: conflicting types for ‘CollationCreate’
>    47 | CollationCreate(const char *collname, Oid collnamespace,
>       | ^~~~~~~~~~~~~~~
> In file included from pg_collation.c:25:
> ../../../src/include/catalog/pg_collation_fn.h:17:12: note: previous
> declaration of ‘CollationCreate’ was here
>    17 | extern Oid CollationCreate(const char *collname, Oid
> collnamespace,
>       |            ^~~~~~~~~~~~~~~

Presumably this is caused by ICU forcibly including <stdbool.h>
and thereby changing what "bool" is.  Since we only started to use
stdbool.h booleans in v11, that's not going to work in v10 or below.

I'm afraid that the short answer is "we're not gonna fix that".
As per the other thread you mentioned, it's possible that we could
make it work by #undef'ing bool in the right places.  But the effort
involved and the likely fragility of the results seem discouraging.

If you want to use a bleeding-edge ICU version, don't use a hoary
Postgres version.

			regards, tom lane





view thread (2+ messages)

Message-ID: <1159815.1608914156@sss.pgh.pa.us>
Permalink:  ../1159815.1608914156@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1159815.1608914156@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, stalkerg@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16791: Compile error with new ICU 68.2 for 10.15
  In-Reply-To: <1159815.1608914156@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox