public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: John Naylor <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
Date: Sun, 05 Apr 2026 23:07:58 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com>
References: <[email protected]>
	<CANWCAZYh-54rBucrL=tJQ5-UzRBUihZfS9wYtz=qUbhmuYJyxQ@mail.gmail.com>
	<[email protected]>
	<CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com>

John Naylor <[email protected]> writes:
> On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <[email protected]> wrote:
>> One could argue that the real bug is having put a .c file into
>> the include/ tree in the first place.  Why was it done like that?
>> Couldn't it be a .h file?

> That was the way it was first coded. I thought of this way to avoid
> adding an exception to headerscheck. I can reverse that decision
> easily, but I may not get to it today.

Ah, the good ol' law of conservation of cruft.  But on the whole
I think naming it .h not .c is less crufty.  Agreed that there's
no great urgency about changing it.

			regards, tom lane

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox