pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Date: Tue, 08 Feb 2022 14:19:53 -0500
Message-ID: <1212293.1644347993@sss.pgh.pa.us> (raw)
In-Reply-To: <9FC8618A-C651-4438-A6A3-7E6682944922@yesql.se>
References: <17391-304f81bcf724b58b@postgresql.org>
	<20220202213900.h7paogmcge2rtls6@alap3.anarazel.de>
	<CA+hUKGJ4+Ug16QU-PYGEZwUe2O69hdnCuyzLhMHHF02_uA4C5w@mail.gmail.com>
	<131329.1643851912@sss.pgh.pa.us>
	<203742.1643866877@sss.pgh.pa.us>
	<C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
	<887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
	<621771.1644098845@sss.pgh.pa.us>
	<635760.1644108785@sss.pgh.pa.us>
	<9FC8618A-C651-4438-A6A3-7E6682944922@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> On 6 Feb 2022, at 01:53, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'd recommend using host='' in the tests, as that more or less
>> replicates what the test author probably expected to happen.

On second thought, using 'localhost' as in your original patch
might be better, simply so that we do exercise the call to
SSL_set_tlsext_host_name.

> Agreed. Are you taking care of that or should I?

It's your patch, feel free.

			regards, tom lane





view thread (44+ messages)  latest in thread

Message-ID: <1212293.1644347993@sss.pgh.pa.us>
Permalink:  ../1212293.1644347993@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1212293.1644347993@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, thomas.munro@gmail.com, andres@anarazel.de, pgsql-bugs@lists.postgresql.org, heikki.linnakangas@iki.fi, michael@paquier.xyz
  Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
  In-Reply-To: <1212293.1644347993@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox