pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: hysong0101@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17909: CREATE SCHEMA AUTHORIZATION sch CREATE TABLE foo ( id INT ) will coredump
Date: Fri, 28 Apr 2023 00:53:39 -0400
Message-ID: <1273138.1682657619@sss.pgh.pa.us> (raw)
In-Reply-To: <ZEtD9rCQGXV10TWV@paquier.xyz>
References: <17909-f65c12dfc5f0451d@postgresql.org>
	<ZEolfwBHm6+znydH@paquier.xyz>
	<CAMbWs4-f5w+YCzqd90YAS-ogPxoahzfJ7C1QUUo8X+KE=0UC4w@mail.gmail.com>
	<ZEpA1SgNzEqhgCvA@paquier.xyz>
	<CAMbWs49CfOfrMp_AGPiBo7g7BusGf2gy1kGSatm-BYO5aeojvQ@mail.gmail.com>
	<ZEr/shjg+8TClUm/@paquier.xyz>
	<1237482.1682639329@sss.pgh.pa.us>
	<ZEsLq0ee/ZKwjf/r@paquier.xyz>
	<ZEskninhkXCQ5jZO@paquier.xyz>
	<CAMbWs49LjsDYOH5QejRKJyqYZSa2Q9j6LJ8Ae4zrvgMw-fYoEQ@mail.gmail.com>
	<ZEtD9rCQGXV10TWV@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Apr 28, 2023 at 11:29:11AM +0800, Richard Guo wrote:
>> BTW, the comment states that CreateSchemaStmtContext.stmtType is "CREATE
>> SCHEMA" or "ALTER SCHEMA".   But it seems that there is no chance to set
>> it to "ALTER SCHEMA".  So should we update that comment, or go even
>> further to remove CreateSchemaStmtContext.stmtType since it is not used?

> Indeed.  I'd be OK with adjusting the comment, without removing
> stmtType to keep some consistency with CreateStmt, and it could be
> useful for debugging, perhaps..  (See 46379d6 as one origin point).

I'd be okay with just dropping that field.  It seems to be much
older than 46379d6, and if it ever had any real use it doesn't now.
(There's no ALTER SCHEMA in the SQL spec at all, let alone one that
has some overlap with CREATE SCHEMA options, so I don't foresee a
future use either.)

			regards, tom lane





view thread (14+ messages)  latest in thread

Message-ID: <1273138.1682657619@sss.pgh.pa.us>
Permalink:  ../1273138.1682657619@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1273138.1682657619@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, guofenglinux@gmail.com, hysong0101@163.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17909: CREATE SCHEMA AUTHORIZATION sch CREATE TABLE foo ( id INT ) will coredump
  In-Reply-To: <1273138.1682657619@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox