pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ruga@protonmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16823: Unreachable code
Date: Wed, 13 Jan 2021 11:42:06 -0500
Message-ID: <1284342.1610556126@sss.pgh.pa.us> (raw)
In-Reply-To: <16823-e67a48abe06eccb9@postgresql.org>
References: <16823-e67a48abe06eccb9@postgresql.org>

PG Bug reporting form <noreply@postgresql.org> writes:
> localtime.c:135:40: warning: code will never be executed
> [-Wunreachable-code]
>                 result -= !TWOS_COMPLEMENT(int32) && result != 0;
>                                                      ^~~~~~

[ and much more in the same vein ]

We're unlikely to change any of these, so I'd recommend turning off
-Wunreachable-code.

localtime.c is a clone of the IANA timezone code, so we're certainly
not going to change it unless they do (which I doubt they would).
bootparse.c, and some of the other files you mention, are code generated
by bison, which we have no control over.  Most of the rest of these
are already manually commented as being unreachable; they're there
partly for belt-and-suspenders reasons, and partly because some other
compilers will warn if we don't have them.

			regards, tom lane





view thread (3+ messages)  latest in thread

Message-ID: <1284342.1610556126@sss.pgh.pa.us>
Permalink:  ../1284342.1610556126@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1284342.1610556126@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ruga@protonmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16823: Unreachable code
  In-Reply-To: <1284342.1610556126@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox