From: Tom Lane <tgl@sss.pgh.pa.us>
To: Venu K <venu2805k@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19826: corr()/regr_r2() of constant input: NULL serially, 1 with partial aggregation
Date: Mon, 02 Nov 2026 22:03:47 -0500
Message-ID: <1382078.1793675027@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEYijEjCz=Sf1Jz9=o1m4zw_KHoj4XVmuXSTynh=2QVW34L1gw@mail.gmail.com>
References: <19826-4b769cb5342fdfe7@postgresql.org>
<CAEYijEjCz=Sf1Jz9=o1m4zw_KHoj4XVmuXSTynh=2QVW34L1gw@mail.gmail.com>
Venu K <venu2805k@gmail.com> writes:
> Attached is a patch for master.
Hm, the actual bug report hasn't come through yet, but I gather your
point is that float8_regr_combine hasn't gotten the word about the
efforts we've made in float8_regr_accum to avoid roundoff error for
all-the-same inputs. Good point, but isn't it also missing the latter
routine's recently-added logic for forcing outputs to NaN when
necessary?
Also, TBH, the proposed comments read like AI slop; they don't
address any of the questions I had on first reading the patch.
Some more effort seems appropriate there.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, venu2805k@gmail.com
Subject: Re: BUG #19826: corr()/regr_r2() of constant input: NULL serially, 1 with partial aggregation
In-Reply-To: <1382078.1793675027@sss.pgh.pa.us>
References: <19826-4b769cb5342fdfe7@postgresql.org> <CAEYijEjCz=Sf1Jz9=o1m4zw_KHoj4XVmuXSTynh=2QVW34L1gw@mail.gmail.com> <1382078.1793675027@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox