pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: schefner20@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster
Date: Mon, 16 Nov 2026 16:51:58 -0500
Message-ID: <148733.1794865918@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoaTDJBjGx7HQBJyCOP3jg=dy--U9ohjF=VUneKPdTrhNQ@mail.gmail.com>
References: <19908-3db6f3c4f2febdcf@postgresql.org>
	<CA+TgmoaY4bO5dh8FXjo=Ec3J=gXHZdFgfQY5pWdKAh7wzPejSA@mail.gmail.com>
	<145931.1794861628@sss.pgh.pa.us>
	<CA+TgmoaTDJBjGx7HQBJyCOP3jg=dy--U9ohjF=VUneKPdTrhNQ@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> I also feel like it's counterintuitive that pg_upgrade --check can
> destroy data, regardless of anything else. One could certainly fail to
> read the documentation and fail to realize that risk.

Perhaps it'd be reasonable for --check mode to not risk a
start_postmaster() action, but just bail out if it sees a
postmaster.pid file.  However, that doesn't do diddly-squat
for what I consider the real hazard here: the described
environment breaks our safeguards against starting two postmasters
in the same data directory.  That WILL eat your data someday,
and there's nothing we can do to prevent it.

			regards, tom lane






view thread (5+ messages)

Message-ID: <148733.1794865918@sss.pgh.pa.us>
Permalink:  ../148733.1794865918@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/148733.1794865918@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, schefner20@gmail.com
  Subject: Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster
  In-Reply-To: <148733.1794865918@sss.pgh.pa.us>
  References: <19908-3db6f3c4f2febdcf@postgresql.org> <CA+TgmoaY4bO5dh8FXjo=Ec3J=gXHZdFgfQY5pWdKAh7wzPejSA@mail.gmail.com> <145931.1794861628@sss.pgh.pa.us> <CA+TgmoaTDJBjGx7HQBJyCOP3jg=dy--U9ohjF=VUneKPdTrhNQ@mail.gmail.com> <148733.1794865918@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox