From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daisuke Higuchi (Fujitsu) <higuchi.daisuke@fujitsu.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17681: Building the REL_12_13 source in Visual Studio 2013 fails.
Date: Thu, 10 Nov 2022 10:24:43 -0500
Message-ID: <160518.1668093883@sss.pgh.pa.us> (raw)
In-Reply-To: <TYWPR01MB967660F1D712C4A387D6B3F9EC019@TYWPR01MB9676.jpnprd01.prod.outlook.com>
References: <17681-485ba2ec13e7f392@postgresql.org>
<3969640.1668005050@sss.pgh.pa.us>
<3977658.1668008266@sss.pgh.pa.us>
<TYWPR01MB967660F1D712C4A387D6B3F9EC019@TYWPR01MB9676.jpnprd01.prod.outlook.com>
"Daisuke Higuchi (Fujitsu)" <higuchi.daisuke@fujitsu.com> writes:
>> #if defined(_MSC_VER) && _MSC_VER < 1900 /* pre-VS2015 */
>> #define snprintf(str,size,...) sprintf(str,__VA_ARGS__)
>> #endif
>> in snprintf.c below where it #undef's snprintf. Could you try that and verify it works for you?
> Thank you! I verified this fix works correctly.
> I confirmed that it succeeded to build the source of REL_12_13 + this fix in Visual Studio 2013.
Excellent. Fix pushed.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, higuchi.daisuke@fujitsu.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17681: Building the REL_12_13 source in Visual Studio 2013 fails.
In-Reply-To: <160518.1668093883@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox