From: Tom Lane <tgl@sss.pgh.pa.us>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15150: Reading uninitialised value in NISortAffixes (tsearch/spell.c)
Date: Fri, 13 Apr 2018 13:51:00 -0400
Message-ID: <16385.1523641860@sss.pgh.pa.us> (raw)
In-Reply-To: <20180413113447.GA32474@zakirov.localdomain>
References: <152353327780.31225.13445405496721177988@wrigleys.postgresql.org>
<20180412115638.GA19444@zakirov.localdomain>
<23884.1523571243@sss.pgh.pa.us>
<20180413113447.GA32474@zakirov.localdomain>
Arthur Zakirov <a.zakirov@postgrespro.ru> writes:
> On Thu, Apr 12, 2018 at 06:14:03PM -0400, Tom Lane wrote:
>> But I see from the code coverage report that this bit is unexercised
>> in the regression tests. Any chance of getting a test that covers
>> this? I'm worried that this means we also lack any coverage of
>> cases where the CompoundAffix array has more than one entry.
> I attached the patch. It fixes the following:
> - show an error if actual number of affix aliases is greater than
> initial number. I wonder is it necessary. But I think it is better to
> raise an error than crash, if you set wrong number for AF flag.
Good idea, but I tweaked the message wording a bit.
> The code coverage still isn't 100% for spell.c. But it is better than
> earlier.
Indeed. Pushed, thanks!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, a.zakirov@postgrespro.ru, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15150: Reading uninitialised value in NISortAffixes (tsearch/spell.c)
In-Reply-To: <16385.1523641860@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox