From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15150: Reading uninitialised value in NISortAffixes (tsearch/spell.c)
Date: Fri, 13 Apr 2018 22:05:30 +0300
Message-ID: <20180413190529.GA6210@arthur.localdomain> (raw)
In-Reply-To: <16385.1523641860@sss.pgh.pa.us>
References: <152353327780.31225.13445405496721177988@wrigleys.postgresql.org>
<20180412115638.GA19444@zakirov.localdomain>
<23884.1523571243@sss.pgh.pa.us>
<20180413113447.GA32474@zakirov.localdomain>
<16385.1523641860@sss.pgh.pa.us>
On Fri, Apr 13, 2018 at 01:51:00PM -0400, Tom Lane wrote:
> > I attached the patch. It fixes the following:
> > - show an error if actual number of affix aliases is greater than
> > initial number. I wonder is it necessary. But I think it is better to
> > raise an error than crash, if you set wrong number for AF flag.
>
> Good idea, but I tweaked the message wording a bit.
>
> > The code coverage still isn't 100% for spell.c. But it is better than
> > earlier.
>
> Indeed. Pushed, thanks!
Thank you!
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: a.zakirov@postgrespro.ru, tgl@sss.pgh.pa.us, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15150: Reading uninitialised value in NISortAffixes (tsearch/spell.c)
In-Reply-To: <20180413190529.GA6210@arthur.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox