pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: cyg0810@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17067: FailedAssertion at castNodeImpl
Date: Mon, 21 Jun 2021 09:33:29 -0400
Message-ID: <1641484.1624282409@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvppyj_WrraCrSgQvDd_NGJp87S6ht6OzjytomMNqa_rxw@mail.gmail.com>
References: <17067-665d50fa321f79e0@postgresql.org>
	<CAApHDvppyj_WrraCrSgQvDd_NGJp87S6ht6OzjytomMNqa_rxw@mail.gmail.com>

David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 21 Jun 2021 at 20:15, PG Bug reporting form
> <noreply@postgresql.org> wrote:
>> run the following sql command through client and the PostgreSQL database
>> process will crash:

> Thanks for the report.  It looks like a thinko in 1d581ce71.   Code
> was added there which insists the initial list element is a List, but
> it's an IntList.  I think the code should just use linitial instead of
> linitial_node.

Hmm, if it's an int-list then the subsequent dup-elimination loop is
also wrong, and for that matter I don't think the preceding lines
would have worked.

> I'm quite surprised that we don't have a test that picks this up.

The code coverage report shows that we *do* have tests that run
through this code, so the existing typing is okay in the test cases
we have.  I'm guessing the real problem is that something upstream is
generating the wrong type of list in this example.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <1641484.1624282409@sss.pgh.pa.us>
Permalink:  ../1641484.1624282409@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1641484.1624282409@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17067: FailedAssertion at castNodeImpl
  In-Reply-To: <1641484.1624282409@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox