pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Егор Чиндяскин <kyzevan23@mail.ru>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Re[2]: BUG #17561: Server crashes on executing row() with very long argument list
Date: Mon, 01 Aug 2022 10:55:38 -0400
Message-ID: <1745216.1659365738@sss.pgh.pa.us> (raw)
In-Reply-To: <CAMbWs4_hj8PFeRWkzndqf=VYj1E3dAKivVxQpdBU6n4DfpgTNw@mail.gmail.com>
References: <20220729101411.7b45rvhlrsgcajjo@alvherre.pgsql>
	<CAMbWs487ax-wLBEQ2be3MJYUUxZYPfmhxHF1gsOb7PQB1tTg=A@mail.gmail.com>
	<3822706.1659113869@sss.pgh.pa.us>
	<1659338229.499665470@f479.i.mail.ru>
	<CAMbWs48GiU-qucoJwH-p0pUY0OnrxZPXQjv7+HGzEPv6D18Vpg@mail.gmail.com>
	<CAMbWs4_1+f7j-HuU1yA298-eeY8GLDqOEmjhiwW-rx6WoNyTYA@mail.gmail.com>
	<CAMbWs4_hj8PFeRWkzndqf=VYj1E3dAKivVxQpdBU6n4DfpgTNw@mail.gmail.com>

Richard Guo <guofenglinux@gmail.com> writes:
> Just noticed that CheckAttributeNamesTypes will check on column count
> against MaxHeapAttributeNumber. Maybe we should use this as the limit?

Yeah, otherwise you'll get a very confusing message about too many
columns in a *table*.

Also, there are two levels we have to check at, per-function and
then the merged tupdesc for the whole RTE.

I should have thought of function RTEs when asserting that there
were no other holes to plug :-(.  Will fix, thanks for the report!

			regards, tom lane





view thread (5+ messages)

Message-ID: <1745216.1659365738@sss.pgh.pa.us>
Permalink:  ../1745216.1659365738@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1745216.1659365738@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, guofenglinux@gmail.com, kyzevan23@mail.ru, alvherre@alvh.no-ip.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: Re[2]: BUG #17561: Server crashes on executing row() with very long argument list
  In-Reply-To: <1745216.1659365738@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox