pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Philip Semanchuk <philip@americanefficient.com>
Cc: Dave Page <dpage@postgresql.org>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16279: Permissions doc incorrect for pg_buffercache
Date: Fri, 28 Feb 2020 11:47:52 -0500
Message-ID: <17654.1582908472@sss.pgh.pa.us> (raw)
In-Reply-To: <6BCF9107-2559-495E-80B8-346921900796@americanefficient.com>
References: <16279-fcaac33c68aab0ab@postgresql.org>
	<21009351582737086@iva6-22e79380f52c.qloud-c.yandex.net>
	<D85A0DF0-A631-43B6-B92D-7B22433B9FA7@americanefficient.com>
	<21597.1582839094@sss.pgh.pa.us>
	<6BCF9107-2559-495E-80B8-346921900796@americanefficient.com>

Philip Semanchuk <philip@americanefficient.com> writes:
>> On Feb 27, 2020, at 4:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Looking at the original discussion, it seems clear that the choice of
>> pg_monitor was intentional; see in particular
>> https://www.postgresql.org/message-id/CA%2BOCxowV7eL-DS1Hr-h5N7Tr8Gvn5VGW%2B%2BYJ2yo6wMN9H3n9Gg%40ma...
>> So I think the code is correct and the documentation is a typo.
>> That's a much easier answer to back-patch, as well.

> Sounds good to me. Thanks for the context!

Re-reading the pg_buffercache documentation, I was reminded that that
view can have a pretty significant performance hit if you've got lots
of shared buffers.  So I think being restrictive about it is good
policy, reinforcing the view that the code made the right choice.

I pushed a patch fixing the docs, in v10 and up.

			regards, tom lane





view thread (6+ messages)

Message-ID: <17654.1582908472@sss.pgh.pa.us>
Permalink:  ../17654.1582908472@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17654.1582908472@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, philip@americanefficient.com, dpage@postgresql.org, simon@2ndquadrant.com, sk@zsrv.org
  Subject: Re: BUG #16279: Permissions doc incorrect for pg_buffercache
  In-Reply-To: <17654.1582908472@sss.pgh.pa.us>
  References: <16279-fcaac33c68aab0ab@postgresql.org> <21009351582737086@iva6-22e79380f52c.qloud-c.yandex.net> <D85A0DF0-A631-43B6-B92D-7B22433B9FA7@americanefficient.com> <21597.1582839094@sss.pgh.pa.us> <6BCF9107-2559-495E-80B8-346921900796@americanefficient.com> <17654.1582908472@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox