pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
Date: Sun, 13 Oct 2019 14:26:48 -0400
Message-ID: <17717.1570991208@sss.pgh.pa.us> (raw)
In-Reply-To: <20191013001032.lqrn4kqaovhrf77l@development>
References: <20191009230759.ge66neof5qj627a2@development>
	<19314.1570663125@sss.pgh.pa.us>
	<20191009232836.jg77wccqwy5fgs6s@development>
	<20265.1570664514@sss.pgh.pa.us>
	<20191010014813.3b2btmkakhrskwgd@alap3.anarazel.de>
	<20191010134303.bkwjzchjb2w66iro@development>
	<30706.1570717152@sss.pgh.pa.us>
	<20191010163350.2rtcjtje6tkgilqi@development>
	<1542.1570738460@sss.pgh.pa.us>
	<20191010204022.6hiiubm2cueu3ghk@development>
	<20191013001032.lqrn4kqaovhrf77l@development>

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> here is an updated patch, with the recursive CTE. I've done a fair
> amount of testing on it on older versions (up to 9.4), and it seems to
> work just fine.

Might be a good idea to exclude attisdropped columns in the part of the
recursive query that's looking for sql_identifier columns of composite
types.  I'm not sure if composites can have dropped columns today,
but even if they can't it seems like a wise bit of future-proofing.
(We'll no doubt have occasion to use this logic again...)

Looks good other than that nit.

> BTW the query (including the RELKIND_COMPSITE_TYPE) was essentially just
> a lightly-massaged copy of old_9_6_check_for_unknown_data_type_usage, so
> that seems wrong too.

Yeah, we should back-port this logic into that check too, IMO.

			regards, tom lane





view thread (30+ messages)  latest in thread

Message-ID: <17717.1570991208@sss.pgh.pa.us>
Permalink:  ../17717.1570991208@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17717.1570991208@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
  In-Reply-To: <17717.1570991208@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox