pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
9+ messages / 5 participants
[nested] [flat]
Commits from this thread:
2023-09-26 e391939b76 doc: PG 16 relnotes: clarify "relation" segsize mention
2023-09-25 a2c2fbf740 72bf3f0877 docs: Clarify --with-segsize-blocks documentation
* BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-21 06:39 PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 9+ messages in thread
From: PG Bug reporting form @ 2023-09-21 06:39 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: harukat@sraoss.co.jp
The following bug has been logged on the website:
Bug reference: 18124
Logged by: TAKATSUKA Haruka
Email address: harukat@sraoss.co.jp
PostgreSQL version: 16.0
Operating system: any
Description:
It seems that "WAL" is unnecessary in the following item.
doc/src/sgml/release-16.sgml:
|<!--
|Author: Andres Freund <andres@anarazel.de>
|2022-12-07 [d3b111e32] Add option to specify segment size in blocks
|-->
|
| <listitem>
| <para>
| Add build option to allow testing of small <acronym>WAL</acronym>
| segment sizes (Andres Freund)
| </para>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-22 01:47 Bruce Momjian <bruce@momjian.us>
parent: PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 9+ messages in thread
From: Bruce Momjian @ 2023-09-22 01:47 UTC (permalink / raw)
To: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Thu, Sep 21, 2023 at 06:39:39AM +0000, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18124
> Logged by: TAKATSUKA Haruka
> Email address: harukat@sraoss.co.jp
> PostgreSQL version: 16.0
> Operating system: any
> Description:
>
> It seems that "WAL" is unnecessary in the following item.
>
> doc/src/sgml/release-16.sgml:
> |<!--
> |Author: Andres Freund <andres@anarazel.de>
> |2022-12-07 [d3b111e32] Add option to specify segment size in blocks
> |-->
> |
> | <listitem>
> | <para>
> | Add build option to allow testing of small <acronym>WAL</acronym>
> | segment sizes (Andres Freund)
> | </para>
Uh, it is true that we don't have any segment sizes other than WAL, but
I am not sure people would easily know that, so I added WAL so people
knew.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-22 01:55 Peter Geoghegan <pg@bowt.ie>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 2 replies; 9+ messages in thread
From: Peter Geoghegan @ 2023-09-22 01:55 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> Uh, it is true that we don't have any segment sizes other than WAL, but
> I am not sure people would easily know that, so I added WAL so people
> knew.
But the commit in question added a new option that can be used to
control the relation segment size -- not the WAL segment size.
Obviously, that's what TAKATSUKA-san meant.
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-22 02:06 Bruce Momjian <bruce@momjian.us>
parent: Peter Geoghegan <pg@bowt.ie>
1 sibling, 1 reply; 9+ messages in thread
From: Bruce Momjian @ 2023-09-22 02:06 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Thu, Sep 21, 2023 at 06:55:09PM -0700, Peter Geoghegan wrote:
> On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> > Uh, it is true that we don't have any segment sizes other than WAL, but
> > I am not sure people would easily know that, so I added WAL so people
> > knew.
>
> But the commit in question added a new option that can be used to
> control the relation segment size -- not the WAL segment size.
> Obviously, that's what TAKATSUKA-san meant.
Oh, I see now, my mistake. How is the attached patch? Thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Attachments:
REL_16_STABLE.diff (text/x-diff, 514B) download
diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index a0a8092120..47b9960f5d 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -3369,8 +3369,8 @@ Author: Andres Freund <andres@anarazel.de>
<listitem>
<para>
- Add build option to allow testing of small <acronym>WAL</acronym>
- segment sizes (Andres Freund)
+ Add build option to allow testing of small table segment sizes
+ (Andres Freund)
</para>
<para>
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-22 02:07 Peter Geoghegan <pg@bowt.ie>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 9+ messages in thread
From: Peter Geoghegan @ 2023-09-22 02:07 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Thu, Sep 21, 2023 at 7:06 PM Bruce Momjian <bruce@momjian.us> wrote:
> Oh, I see now, my mistake. How is the attached patch? Thanks.
LGTM.
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-22 02:08 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Geoghegan <pg@bowt.ie>
1 sibling, 1 reply; 9+ messages in thread
From: Tom Lane @ 2023-09-22 02:08 UTC (permalink / raw)
To: Peter Geoghegan <pg@bowt.ie>; +Cc: Bruce Momjian <bruce@momjian.us>; harukat@sraoss.co.jp, pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Peter Geoghegan <pg@bowt.ie> writes:
> On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
>> Uh, it is true that we don't have any segment sizes other than WAL, but
>> I am not sure people would easily know that, so I added WAL so people
>> knew.
> But the commit in question added a new option that can be used to
> control the relation segment size -- not the WAL segment size.
> Obviously, that's what TAKATSUKA-san meant.
Yeah. The release note entry is simply wrong to say it's WAL segment
size. I would also argue that d3b111e32's installation.sgml changes
were poorly worded, because they only say "segment size" which can
easily be misunderstood, just as happened here. Better would be
"relation segment size" or "table segment size".
regards, tom lane
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-25 17:45 Andres Freund <andres@anarazel.de>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 9+ messages in thread
From: Andres Freund @ 2023-09-25 17:45 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Geoghegan <pg@bowt.ie>; Bruce Momjian <bruce@momjian.us>; harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
Hi,
On 2023-09-21 22:08:18 -0400, Tom Lane wrote:
> Peter Geoghegan <pg@bowt.ie> writes:
> > On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> >> Uh, it is true that we don't have any segment sizes other than WAL, but
> >> I am not sure people would easily know that, so I added WAL so people
> >> knew.
>
> > But the commit in question added a new option that can be used to
> > control the relation segment size -- not the WAL segment size.
> > Obviously, that's what TAKATSUKA-san meant.
>
> Yeah. The release note entry is simply wrong to say it's WAL segment size.
Agreed. Bruce are you committing that bit?
> I would also argue that d3b111e32's installation.sgml changes
> were poorly worded, because they only say "segment size" which can
> easily be misunderstood, just as happened here. Better would be
> "relation segment size" or "table segment size".
Hm. Yea. I copied the language from --with-segsize, but there there's
subsequent sentences that do clarify what the option relates to. I prefer
"relation" over "table" as it affects indexes as well.
Pushed that adjustment.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-25 22:32 Bruce Momjian <bruce@momjian.us>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 9+ messages in thread
From: Bruce Momjian @ 2023-09-25 22:32 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Peter Geoghegan <pg@bowt.ie>; harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Mon, Sep 25, 2023 at 10:45:04AM -0700, Andres Freund wrote:
> Hi,
>
> On 2023-09-21 22:08:18 -0400, Tom Lane wrote:
> > Peter Geoghegan <pg@bowt.ie> writes:
> > > On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> > >> Uh, it is true that we don't have any segment sizes other than WAL, but
> > >> I am not sure people would easily know that, so I added WAL so people
> > >> knew.
> >
> > > But the commit in question added a new option that can be used to
> > > control the relation segment size -- not the WAL segment size.
> > > Obviously, that's what TAKATSUKA-san meant.
> >
> > Yeah. The release note entry is simply wrong to say it's WAL segment size.
>
> Agreed. Bruce are you committing that bit?
Yes, I will try to do it tomorrow.
> > I would also argue that d3b111e32's installation.sgml changes
> > were poorly worded, because they only say "segment size" which can
> > easily be misunderstood, just as happened here. Better would be
> > "relation segment size" or "table segment size".
>
> Hm. Yea. I copied the language from --with-segsize, but there there's
> subsequent sentences that do clarify what the option relates to. I prefer
> "relation" over "table" as it affects indexes as well.
>
> Pushed that adjustment.
Thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
@ 2023-09-26 16:09 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 9+ messages in thread
From: Bruce Momjian @ 2023-09-26 16:09 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Peter Geoghegan <pg@bowt.ie>; harukat@sraoss.co.jp; pgsql-bugs@lists.postgresql.org
On Mon, Sep 25, 2023 at 06:32:48PM -0400, Bruce Momjian wrote:
> On Mon, Sep 25, 2023 at 10:45:04AM -0700, Andres Freund wrote:
> > Hi,
> >
> > On 2023-09-21 22:08:18 -0400, Tom Lane wrote:
> > > Peter Geoghegan <pg@bowt.ie> writes:
> > > > On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> > > >> Uh, it is true that we don't have any segment sizes other than WAL, but
> > > >> I am not sure people would easily know that, so I added WAL so people
> > > >> knew.
> > >
> > > > But the commit in question added a new option that can be used to
> > > > control the relation segment size -- not the WAL segment size.
> > > > Obviously, that's what TAKATSUKA-san meant.
> > >
> > > Yeah. The release note entry is simply wrong to say it's WAL segment size.
> >
> > Agreed. Bruce are you committing that bit?
>
> Yes, I will try to do it tomorrow.
Patch applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2023-09-26 16:09 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21 06:39 BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes" PG Bug reporting form <noreply@postgresql.org>
2023-09-22 01:47 ` Bruce Momjian <bruce@momjian.us>
2023-09-22 01:55 ` Peter Geoghegan <pg@bowt.ie>
2023-09-22 02:06 ` Bruce Momjian <bruce@momjian.us>
2023-09-22 02:07 ` Peter Geoghegan <pg@bowt.ie>
2023-09-22 02:08 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-09-25 17:45 ` Andres Freund <andres@anarazel.de>
2023-09-25 22:32 ` Bruce Momjian <bruce@momjian.us>
2023-09-26 16:09 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox