From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: harukat@sraoss.co.jp
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
Date: Mon, 25 Sep 2023 18:32:48 -0400
Message-ID: <ZRIKkGooA9i9yTrw@momjian.us> (raw)
In-Reply-To: <20230925174504.tldeeux5atf5zawf@alap3.anarazel.de>
References: <18124-d363fa4873e176d6@postgresql.org>
<ZQzyO25k1xuHF4Ts@momjian.us>
<CAH2-Wzk+8CwQAaT1SSwQ1FmX-TNQEkw6QcndPYVc2Nd1v1DiMA@mail.gmail.com>
<837536.1695348498@sss.pgh.pa.us>
<20230925174504.tldeeux5atf5zawf@alap3.anarazel.de>
On Mon, Sep 25, 2023 at 10:45:04AM -0700, Andres Freund wrote:
> Hi,
>
> On 2023-09-21 22:08:18 -0400, Tom Lane wrote:
> > Peter Geoghegan <pg@bowt.ie> writes:
> > > On Thu, Sep 21, 2023 at 6:47 PM Bruce Momjian <bruce@momjian.us> wrote:
> > >> Uh, it is true that we don't have any segment sizes other than WAL, but
> > >> I am not sure people would easily know that, so I added WAL so people
> > >> knew.
> >
> > > But the commit in question added a new option that can be used to
> > > control the relation segment size -- not the WAL segment size.
> > > Obviously, that's what TAKATSUKA-san meant.
> >
> > Yeah. The release note entry is simply wrong to say it's WAL segment size.
>
> Agreed. Bruce are you committing that bit?
Yes, I will try to do it tomorrow.
> > I would also argue that d3b111e32's installation.sgml changes
> > were poorly worded, because they only say "segment size" which can
> > easily be misunderstood, just as happened here. Better would be
> > "relation segment size" or "table segment size".
>
> Hm. Yea. I copied the language from --with-segsize, but there there's
> subsequent sentences that do clarify what the option relates to. I prefer
> "relation" over "table" as it affects indexes as well.
>
> Pushed that adjustment.
Thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, andres@anarazel.de, tgl@sss.pgh.pa.us, pg@bowt.ie, harukat@sraoss.co.jp
Subject: Re: BUG #18124: PG16 release note document bug in "Add build option to allow testing of small WAL segment sizes"
In-Reply-To: <ZRIKkGooA9i9yTrw@momjian.us>
References: <18124-d363fa4873e176d6@postgresql.org> <ZQzyO25k1xuHF4Ts@momjian.us> <CAH2-Wzk+8CwQAaT1SSwQ1FmX-TNQEkw6QcndPYVc2Nd1v1DiMA@mail.gmail.com> <837536.1695348498@sss.pgh.pa.us> <20230925174504.tldeeux5atf5zawf@alap3.anarazel.de> <ZRIKkGooA9i9yTrw@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox