pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: pm91.arapov@gmail.com
Subject: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
Date: Fri, 14 Mar 2025 09:16:06 +0000
Message-ID: <18850-20d329c520d6a64e@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      18850
Logged by:          Nikita
Email address:      pm91.arapov@gmail.com
PostgreSQL version: 16.6
Operating system:   ubuntu 20.04
Description:        

REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

diff --git a/src/backend/commands/operatorcmds.c
b/src/backend/commands/operatorcmds.c
--- a/src/backend/commands/operatorcmds.c	(revision
a49ac80219c6f28c3cf3973f797de637329952da)
+++ b/src/backend/commands/operatorcmds.c	(date 1740387217614)
@@ -209,11 +209,6 @@
 		typeId[0] = typeId2;
 		nargs = 1;
 	}
-	else if (!OidIsValid(typeId2))
-	{
-		typeId[0] = typeId1;
-		nargs = 1;
-	}
 	else
 	{
 		typeId[0] = typeId1;

I suggest the following patch fixing this issue



view thread (2+ messages)  latest in thread

Message-ID: <18850-20d329c520d6a64e@postgresql.org>
Permalink:  ../18850-20d329c520d6a64e@postgresql.org/
Also on:    postgresql.org/message-id/18850-20d329c520d6a64e@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, pgsql-bugs@lists.postgresql.org, pm91.arapov@gmail.com
  Subject: Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
  In-Reply-To: <18850-20d329c520d6a64e@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox