From: Tom Lane <tgl@sss.pgh.pa.us>
To: pm91.arapov@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
Date: Fri, 14 Mar 2025 10:32:04 -0400
Message-ID: <3055986.1741962724@sss.pgh.pa.us> (raw)
In-Reply-To: <18850-20d329c520d6a64e@postgresql.org>
References: <18850-20d329c520d6a64e@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
Let's see, in #18848 and #18849 you were complaining about
non-robust code, but here you want to remove robustness?
I think it's fine as-is. (The back story here is that we
used to support postfix operators, so the earlier error
for !OidIsValid(typeId2) postdates this bit. While I don't
think that support is ever coming back, I'm disinclined to
remove a couple of lines that would be important for it.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pm91.arapov@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison
In-Reply-To: <3055986.1741962724@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox