pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
BUG #18889: /src/backend/utils/adt/network.c condition is always false
2+ messages / 2 participants
[nested] [flat]

* BUG #18889: /src/backend/utils/adt/network.c condition is always false
@ 2025-04-10 16:41 PG Bug reporting form <noreply@postgresql.org>
  2025-04-10 18:19 ` Re: BUG #18889: /src/backend/utils/adt/network.c condition is always false Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 2+ messages in thread

From: PG Bug reporting form @ 2025-04-10 16:41 UTC (permalink / raw)
  To: pgsql-bugs@lists.postgresql.org; +Cc: dan-eli@mail.ru

The following bug has been logged on the website:

Bug reference:      18889
Logged by:          Daniel Elishakov
Email address:      dan-eli@mail.ru
PostgreSQL version: 17.4
Operating system:   Ubuntu 20.04
Description:        

On line 282 there is a check of nb < 0, which is always false, so i think it
is better to be replaced with 'Assert(nb > 0);'



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: BUG #18889: /src/backend/utils/adt/network.c condition is always false
  2025-04-10 16:41 BUG #18889: /src/backend/utils/adt/network.c condition is always false PG Bug reporting form <noreply@postgresql.org>
@ 2025-04-10 18:19 ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2025-04-10 18:19 UTC (permalink / raw)
  To: dan-eli@mail.ru; +Cc: pgsql-bugs@lists.postgresql.org

PG Bug reporting form <noreply@postgresql.org> writes:
> On line 282 there is a check of nb < 0, which is always false, so i think it
> is better to be replaced with 'Assert(nb > 0);'

This one I do agree with getting rid of --- in fact, I don't
even see a need for an Assert.  Done at f27eb0325.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-04-10 18:19 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-04-10 16:41 BUG #18889: /src/backend/utils/adt/network.c condition is always false PG Bug reporting form <noreply@postgresql.org>
2025-04-10 18:19 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox