pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: dan-eli@mail.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18889: /src/backend/utils/adt/network.c condition is always false
Date: Thu, 10 Apr 2025 14:19:52 -0400
Message-ID: <593243.1744309192@sss.pgh.pa.us> (raw)
In-Reply-To: <18889-73d4f19e953a629e@postgresql.org>
References: <18889-73d4f19e953a629e@postgresql.org>

PG Bug reporting form <noreply@postgresql.org> writes:
> On line 282 there is a check of nb < 0, which is always false, so i think it
> is better to be replaced with 'Assert(nb > 0);'

This one I do agree with getting rid of --- in fact, I don't
even see a need for an Assert.  Done at f27eb0325.

			regards, tom lane





view thread (2+ messages)

Message-ID: <593243.1744309192@sss.pgh.pa.us>
Permalink:  ../593243.1744309192@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/593243.1744309192@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dan-eli@mail.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18889: /src/backend/utils/adt/network.c condition is always false
  In-Reply-To: <593243.1744309192@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox