pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: David E. Wheeler <david@justatheory.com>
Cc: Christophe Pettus <christophe.pettus@pgexperts.com>
Cc: pgsql-bugs@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] BUG #14825: enum type: unsafe use?
Date: Tue, 26 Sep 2017 18:49:39 -0400
Message-ID: <19030.1506466179@sss.pgh.pa.us> (raw)
In-Reply-To: <32160eb9-60df-746b-bbc0-dd232b993d6d@2ndQuadrant.com>
References: <27064.1506350579@sss.pgh.pa.us>
	<5f4f29bf-90b1-e49a-6cf9-069c59bc1067@2ndQuadrant.com>
	<40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com>
	<1090.1506365074@sss.pgh.pa.us>
	<9666.1506446327@sss.pgh.pa.us>
	<329.1506451066@sss.pgh.pa.us>
	<38835cdd-!c378-8d7a-013b-fd733c78c649@2ndQuadrant.com>
	<12792.1506456422@sss.pgh.pa.us>
	<20170926211419.GB7167@momjian.us>
	<16025.1506461535@sss.pgh.pa.us>
	<20170926214548.GQ4628@tamriel.snowman.net>
	<5161729c-4597-8a41-f4e2-c7d97e84d86e@2ndQuadrant.com>
	<32160eb9-60df-746b-bbc0-dd232b993d6d@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> I'm not happy about the idea of marking an input function as not
> parallel safe, certainly not without a good deal of thought and
> discussion that we don't have time for this cycle.

Yeah, that aspect of it was bothering me too: it's easy to say
"mark the function unsafe", but that only helps to the extent that
the function is used in queries where the planner has control of
whether to parallelize or not.  There's an awful lot of hard-wired
calls to I/O functions in our code, and I would not want to promise
that none of those are reachable in a parallel worker.

As for Stephen's concern, I had already looked at reverting 15bc038f9
earlier, and concluded that none of that code had changed significantly
since then.  There's some conflicts due to pgindent activity but I think
pulling it out will be a straightforward thing to do.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (48+ messages)  latest in thread

Message-ID: <19030.1506466179@sss.pgh.pa.us>
Permalink:  ../19030.1506466179@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19030.1506466179@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, sfrost@snowman.net, bruce@momjian.us, david@justatheory.com, christophe.pettus@pgexperts.com, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] BUG #14825: enum type: unsafe use?
  In-Reply-To: <19030.1506466179@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox