pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-bugs@postgresql.org <pgsql-bugs@postgresql.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Schneider (AWS), Jeremy <schnjere@amazon.com>
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Date: Wed, 11 Dec 2019 12:11:03 -0500
Message-ID: <19042.1576084263@sss.pgh.pa.us> (raw)
In-Reply-To: <20191211163522.t2ljtydarlmusoix@alap3.anarazel.de>
References: <E1i74JE-00024V-9J@gemulon.postgresql.org>
	<b1da9abc-bad7-efd6-2f1c-503d508c3877@amazon.com>
	<20191205133836.lulisfo2fphdrjp3@development>
	<EEB686D3-F8A7-4371-9A96-5DF3B72A7734@amazon.com>
	<20191211163522.t2ljtydarlmusoix@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> This indicates that a toast record was present for that relation,
> despite:
> [ \d that looks like the table isn't wide enough for that ]
> I think we need to see pg_waldump output for the preceding records. That
> might allow us to see why there's a toast record that's being associated
> with this table, despite there not being a toast table.

I don't think you can make that conclusion.  Perhaps the table once
needed a toast table because of some wide column that got dropped;
if so, it'd still have one.  It'd be safer to look at
pg_class.reltoastrelid to verify existence (or not) of the toast relation.

It strikes me that there could easily be cases where a publisher table
has a toast relation and a subscriber's doesn't ... maybe this code
isn't expecting that?

			regards, tom lane





view thread (21+ messages)  latest in thread

Message-ID: <19042.1576084263@sss.pgh.pa.us>
Permalink:  ../19042.1576084263@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19042.1576084263@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, bdrouvot@amazon.com, tomas.vondra@2ndquadrant.com, pgsql-hackers@postgresql.org, schnjere@amazon.com
  Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
  In-Reply-To: <19042.1576084263@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox