From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: jazz001319@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
Date: Wed, 05 Apr 2023 12:57:29 -0400
Message-ID: <2005410.1680713849@sss.pgh.pa.us> (raw)
In-Reply-To: <20230405073356.boweefqo5ec4dfhe@alvherre.pgsql>
References: <20230405073356.boweefqo5ec4dfhe@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2023-Apr-04, Tom Lane wrote:
>> I'm inclined to think that in the older branches (pre f4566345c)
>> we need to do
>> - if (oldtrig->tgisinternal)
>> + if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
>> but I've not tested that. Alvaro, what do you think?
> Oh, that's a nice and clean solution. I tested it (on 13 and 14) and it
> does solve the problem, and no regression tests fail, but I didn't try
> to break it further. 12 and back are unaffected, for lack of
> 86f575948c77.
Pushed, thanks for looking at it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, jazz001319@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
In-Reply-To: <2005410.1680713849@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox