pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Janes <jeff.janes@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
Date: Mon, 02 Nov 2015 05:58:41 +0000
Message-ID: <20151102055841.2561.61366.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CAB7nPqS-joTOdjqBUYGdawVcOw5UwrMZf+vOdzzbgHtDBg6SRg@mail.gmail.com>
References: <20151016203031.3019.72930@wrigleys.postgresql.org>
	<CAB7nPqS-joTOdjqBUYGdawVcOw5UwrMZf+vOdzzbgHtDBg6SRg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Simple patch, applies and makes cleanly, does what it says and says what it does.

If a transaction holding locks aborts on an otherwise idle server, perhaps it will take a very long time for a log-shipping standby to realize this.  But I have hard time believing that anyone who cares about that would be using log-shipping (rather than streaming) anyway.

Marking it ready for committer.

The new status of this patch is: Ready for Committer


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (87+ messages)  latest in thread

Message-ID: <20151102055841.2561.61366.pgcf@coridan.postgresql.org>
Permalink:  ../20151102055841.2561.61366.pgcf@coridan.postgresql.org/
Also on:    postgresql.org/message-id/20151102055841.2561.61366.pgcf@coridan.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: jeff.janes@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
  In-Reply-To: <20151102055841.2561.61366.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox