From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: brown@fastmail.com, "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Subject: Re: BUG #13741: vacuumdb does not accept valid password
Date: Thu, 12 Nov 2015 18:58:41 -0300
Message-ID: <20151112215841.GS614468@alvherre.pgsql> (raw)
In-Reply-To: <21797.1447365082@sss.pgh.pa.us>
References: <CAJrrPGeXuav-OYjJYKwSaLt+aOU+emH4a5XZS3XfMHNfanUmnw@mail.gmail.com>
<CAJrrPGetAZVhE=0YJY5idTYtSt2o1LCkkC9aQaw81kJg2RyWuw@mail.gmail.com>
<20151104021618.GP6104@alvherre.pgsql>
<CAB7nPqSazOE_bB7koqHOY2gYM6vPs9e3D158ZCjxyJ61p1Ra8Q@mail.gmail.com>
<CAB7nPqTq5PfQbMMCqJ4KRM8Q1ppOgVu4WziuEzm=3TNUN5wUoA@mail.gmail.com>
<CAHGQGwHx0BvxTDpo2xXS--gEJFQjjrTP4BZY8wRzUfPYakzEgQ@mail.gmail.com>
<20151112170303.GN614468@alvherre.pgsql>
<15139.1447357263@sss.pgh.pa.us>
<20151112212627.GR614468@alvherre.pgsql>
<21797.1447365082@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Thanks for the input. I decided to push what we had because it's less
> > invasive in terms of API definition.
>
> I dunno, this might be easier for the callers that don't want password
> re-use, but it seems quite horrid for ones that do. The changes to
> vacuumdb.c are, frankly, seriously ugly; and they require vacuumdb.c
> to know a lot more than before about password handling.
Yes, it is ugly.
> Other notes are that the strdup() call should surely be pg_strdup(),
> and the mix of free() and pg_free() is at best unsightly.
I had the same comment, but it turns out that free and strdup must be
used instead because sprompt.c uses malloc in the equivalent places; and
we can't use pg_malloc there because it's in src/port which isn't
allowed to use fe_memutils. We would have to move it from src/port to
src/common first.
> The place I was thinking we might end up was something like Fujii-san's
> patch plus a new bool parameter "allow_password_reuse", which could be
> passed as false in cases where the old behavior seems preferable.
Hm, we can try that.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, masao.fujii@gmail.com, michael.paquier@gmail.com, kommi.haribabu@gmail.com
Subject: Re: BUG #13741: vacuumdb does not accept valid password
In-Reply-To: <20151112215841.GS614468@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox