pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: TipTop Labs <office@tiptop-labs.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control
Date: Mon, 5 Mar 2018 18:01:11 +0900
Message-ID: <20180305090111.GI2266@paquier.xyz> (raw)
In-Reply-To: <CAD21AoDiHUUguQ7UUyK_Z4icHM3OiP8OEkpgDCsT3fg3B-P2LA@mail.gmail.com>
References: <20180104200633.17004.16377@wrigleys.postgresql.org>
	<CAB7nPqTyq3cjphJmoCPc0n8r90O4j1BpZC2BMaj8dKZ7g0-mtw@mail.gmail.com>
	<0D104D1E-6103-49F4-8AB8-B5CD92949E18@tiptop-labs.com>
	<20180115072537.GC1724@paquier.xyz>
	<D2684F73-AE17-453B-ACB5-9CF0A7F6856E@tiptop-labs.com>
	<20180227012441.GB3255@paquier.xyz>
	<CA+q6zcWeFmGc=uC5CwL7HznL25nCqh0CvepgtyuGQo1duStE+w@mail.gmail.com>
	<20180305075431.GH2266@paquier.xyz>
	<CAD21AoDiHUUguQ7UUyK_Z4icHM3OiP8OEkpgDCsT3fg3B-P2LA@mail.gmail.com>

On Mon, Mar 05, 2018 at 05:47:06PM +0900, Masahiko Sawada wrote:
> Since files other than relation files such as vm, fsm, WAL are
> categorize as FILE_ACTION_COPY_CONFIG, I think the name would cause
> misreading. For example, we can use FILE_ACTION_COPY_DATA and
> FILE_ACTION_COPY_OTHER?

I am not stopped on a given name.

> As you mentioned before, with this patch we end up ignoring file-open
> error of database files other than relation files. I guess it's a bit
> risky. We can enter them to COPY_DATA but I'd defer it to committer.

COPY_DATA is aimed at being used on files which can be parsed by
blocks.  You cannot do that with VMs and FSMs.  Now you are true that we 
could complain for non-configuration files which need to be
fully-copied, still Postgres issues a fsync on all the files of the data
folder when beginning recovery, so you would bump on problems anyway
after restarting the rewound instance.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20180305090111.GI2266@paquier.xyz/2-signature.asc)
  download

view thread (29+ messages)  latest in thread

Message-ID: <20180305090111.GI2266@paquier.xyz>
Permalink:  ../20180305090111.GI2266@paquier.xyz/
Also on:    postgresql.org/message-id/20180305090111.GI2266@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, sawada.mshk@gmail.com, 9erthalion6@gmail.com, office@tiptop-labs.com, michael.paquier@gmail.com
  Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control
  In-Reply-To: <20180305090111.GI2266@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox