From: Michael Paquier <michael@paquier.xyz>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: andres@anarazel.de <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: robertmhaas@gmail.com <robertmhaas@gmail.com>
Cc: Schneider, Jeremy <schnjere@amazon.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: lalbin@scharp.org <lalbin@scharp.org>
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Date: Sat, 28 Jul 2018 09:10:12 +0900
Message-ID: <20180728001012.GC1882@paquier.xyz> (raw)
In-Reply-To: <62728D88-85A0-4A9A-A4F8-67D96C1179E0@amazon.com>
References: <20180726204127.GA1754@paquier.xyz>
<3D4F2733-92AE-4B74-8912-3C611B027721@amazon.com>
<20180727023123.GE1754@paquier.xyz>
<20180727.123702.77822416.horiguchi.kyotaro@lab.ntt.co.jp>
<20180727041542.GH1754@paquier.xyz>
<62728D88-85A0-4A9A-A4F8-67D96C1179E0@amazon.com>
On Fri, Jul 27, 2018 at 02:40:42PM +0000, Bossart, Nathan wrote:
> On 7/26/18, 11:16 PM, "Michael Paquier" <michael@paquier.xyz> wrote:
> I think I'm essentially suggesting what you have in 0002 but without
> the new RangeVarGetRelidExtended() callback. I've attached a modified
> version of 0002 that seems to fix the originally reported issue. (I
> haven't looked into any extra handling needed for ANALYZE or
> partitioned tables.) Running the same checks for all VACUUMs would
> keep things simple and provide a more uniform user experience.
Okay, let me check that. Your patch has at least an error in
get_all_vacuum_rels() where toast relations cannot be skipped.
>> The docs mentioned that shared catalogs are processed, so I did not
>> bother, but visibly your comment is that we could be more precise about
>> the ownership in this case? An attempt is attached.
>
> Sorry, I should have been clearer. But yes, your update is what I was
> thinking.
No problem. If there are no objections, I am going to fix the REINDEX
issue first and back-patch. Its patch is the least invasive of the
set.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180728001012.GC1882@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, bossartn@amazon.com, horiguchi.kyotaro@lab.ntt.co.jp, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, robertmhaas@gmail.com, schnjere@amazon.com, pgsql-hackers@postgresql.org, lalbin@scharp.org
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
In-Reply-To: <20180728001012.GC1882@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox