pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeremy Evans <code@jeremyevans.net>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Date: Sat, 8 Sep 2018 12:31:58 -0700
Message-ID: <20180908193158.GH32058@paquier.xyz> (raw)
In-Reply-To: <16558.1536407783@sss.pgh.pa.us>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
	<20180906215836.GP2726@paquier.xyz>
	<20180906222843.GF17425@jeremyevans.local>
	<20180907165103.GH17425@jeremyevans.local>
	<20180907175518.GI17425@jeremyevans.local>
	<20180907181522.GB32058@paquier.xyz>
	<20016.1536351535@sss.pgh.pa.us>
	<20180907204403.GC32058@paquier.xyz>
	<16558.1536407783@sss.pgh.pa.us>

On Sat, Sep 08, 2018 at 07:56:23AM -0400, Tom Lane wrote:
> Looking closer, there are no leaks, though I think we could use a comment
> about that.  And it still makes me itch that pg_saslprep (mostly) doesn't
> worry about clearing *output on failure while only three of its four
> callers bother to initialize their variables to null.  That's a recipe
> for future bugs.  So I propose the attached cleanup.

Okay, that looks acceptable to me.  Thanks for looking at that.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (33+ messages)  latest in thread

Message-ID: <20180908193158.GH32058@paquier.xyz>
Permalink:  ../20180908193158.GH32058@paquier.xyz/
Also on:    postgresql.org/message-id/20180908193158.GH32058@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, code@jeremyevans.net, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
  In-Reply-To: <20180908193158.GH32058@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox