From: Michael Paquier <michael@paquier.xyz>
To: harukat@sraoss.co.jp
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15402: Hot standby server with archive_mode=on keeps initial WAL segments
Date: Wed, 26 Sep 2018 12:52:05 +0900
Message-ID: <20180926035205.GJ1659@paquier.xyz> (raw)
In-Reply-To: <15402-a453c90ed4cf88b2@postgresql.org>
References: <15402-a453c90ed4cf88b2@postgresql.org>
On Wed, Sep 26, 2018 at 03:26:50AM +0000, PG Bug reporting form wrote:
> A hot standby server with “archive_mode = on” keeps initial WAL segment
> files that copied by pg_basebackup. It shows the following status.
> 000000010000000000000042 will be kept forever in this case.
How did you find yourself in this situation? Did you take a base backup
from a primary which had .ready files in it, and those got copied to the
standby's data folder? We may want to study the possibility of
filtering things when taking a base backup instead.
> Though I understand renaming the .ready to .done manually can clean it,
> I would like to fix the server code like the following patch.
> I'd appreciate if you would consider that.
Your patch looks incorrect to me to begin with... What if archive_mode
is switched from "on" to "always" back-and-forth and there some of the
past segments which should be archived are not?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180926035205.GJ1659@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, harukat@sraoss.co.jp, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15402: Hot standby server with archive_mode=on keeps initial WAL segments
In-Reply-To: <20180926035205.GJ1659@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox